Joy axis update #1483
Merged
Joy axis update #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some controllers (such as wireless Xbox 360 controllers on Linux) use the same names for both buttons and controllers (i.e. both the right trigger axis and the right bumper button are named "5").
This allows developers to restrict a certain axis to a bound set of values (for example, preventing a one-way trigger access from going below 0, or compensating for a damaged joystick.
Better for backwards compatibility.
Member
|
Thanks for contributing! |
stephengold
reviewed
Mar 19, 2021
jme3-core/src/main/java/com/jme3/input/JoystickCompatibilityMappings.java
Outdated
Show resolved
Hide resolved
stephengold
reviewed
Mar 19, 2021
jme3-core/src/main/java/com/jme3/input/JoystickCompatibilityMappings.java
Outdated
Show resolved
Hide resolved
stephengold
reviewed
Mar 19, 2021
jme3-core/src/main/java/com/jme3/input/JoystickCompatibilityMappings.java
Outdated
Show resolved
Hide resolved
stephengold
reviewed
Mar 19, 2021
jme3-core/src/main/java/com/jme3/input/JoystickCompatibilityMappings.java
Show resolved
Hide resolved
stephengold
reviewed
Mar 19, 2021
jme3-core/src/main/java/com/jme3/input/JoystickCompatibilityMappings.java
Show resolved
Hide resolved
stephengold
reviewed
Mar 19, 2021
jme3-core/src/main/java/com/jme3/input/JoystickCompatibilityMappings.java
Outdated
Show resolved
Hide resolved
stephengold
reviewed
Mar 19, 2021
jme3-core/src/main/java/com/jme3/input/JoystickCompatibilityMappings.java
Outdated
Show resolved
Hide resolved
stephengold
reviewed
Mar 19, 2021
# Conflicts: # jme3-core/src/main/java/com/jme3/input/JoystickCompatibilityMappings.java # jme3-core/src/main/java/com/jme3/input/event/JoyAxisEvent.java # jme3-lwjgl/src/main/java/com/jme3/input/lwjgl/JInputJoyInput.java
stephengold
reviewed
Mar 23, 2021
jme3-lwjgl/src/main/java/com/jme3/input/lwjgl/JInputJoyInput.java
Outdated
Show resolved
Hide resolved
stephengold
reviewed
Mar 23, 2021
jme3-lwjgl/src/main/java/com/jme3/input/lwjgl/JInputJoyInput.java
Outdated
Show resolved
Hide resolved
stephengold
approved these changes
Mar 24, 2021
Member
stephengold
left a comment
stephengold
left a comment
There was a problem hiding this comment.
Next time, please don't reformat the code (unless that's the main purpose of the PR). It makes code review unnecessarily difficult.
Contributor
Author
|
Right. Sorry for the pain. I still haven't figured out entirely how to get Android Studio to match your formatting standards entirely. |
Member
|
Getting Android Studio to match our formatting standards isn't the issue here. The standards are relatively recent, and most existing code doesn't meet those standards. The key thing for PRs like this is to prevent Android Studio from reformatting existing code! |
Member
|
Unless there's substantive discussion of this PR, I plan to integrate it in about 8 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hub.jmonkeyengine.org/t/joystickcompatibilitymappings-overhaul/44337
This PR adds two improvements to the JoystickCompatabilityMapping class: First of all, it allows the remapping file to specify whether a mapping is a buttom remapping or an axis remapping. Considering some gamepads will use the same name for a button and an axis, this feature will help in this field. It is an optional, backwards-compatible feature that can be enabled by adding "button." or "axis." in front of the property name.
The second change is the ability to change the effective range of axes by adding a bracketed tupple of two floats to the value
axis.Xbox\ 360\ Wireless\ Receiver.z=rx[0.0,1.0]Note that the "axis." prefix is optional, and using the range remapper implies that this remapping is for axes.