Skip to content

resolve issue #1461 (protect no-arg Camera constructor) #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephengold merged 1 commit into from
Feb 10, 2021
Merged

resolve issue #1461 (protect no-arg Camera constructor) #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jme3-core/src/main/java/com/jme3/renderer/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2009-2020 jMonkeyEngine
* Copyright (c) 2009-2021 jMonkeyEngine
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -207,7 +207,7 @@ public enum FrustumIntersect {
/**
* Serialization only. Do not use.
*/
public Camera() {
protected Camera() {
worldPlane = new Plane[MAX_WORLD_PLANES];
for (int i = 0; i < MAX_WORLD_PLANES; i++) {
worldPlane[i] = new Plane();
Expand Down
4 changes: 2 additions & 2 deletions jme3-vr/src/main/java/com/jme3/app/VRApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ public VRApplication() {

guiNode.setQueueBucket(Bucket.Gui);
guiNode.setCullHint(CullHint.Never);
dummyCam = new Camera();
dummyCam = new Camera(0, 0);

initStateManager();

Expand Down Expand Up @@ -1548,4 +1548,4 @@ public void setAppProfiler(AppProfiler prof) {
public AppProfiler getAppProfiler() {
return null;
}
}
}
2 changes: 1 addition & 1 deletion jme3-vr/src/main/java/com/jme3/app/VREnvironment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ public Camera getDummyCamera(){
if ((settings != null) && (settings.getWidth() != 0) && (settings.getHeight() != 0)){
dummyCam = new Camera(settings.getWidth(), settings.getHeight());
} else {
dummyCam = new Camera();
dummyCam = new Camera(0, 0);
}
}
} else {
Expand Down