Gltf unlit #1463
Merged
Gltf unlit #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for your contribution to JMonkeyEngine! |
Member
|
Do you understand the cause of the "AssetNotFoundException: gltf/scene/map.gltf"? |
Contributor
Author
|
It appears that there is a file missing that one of the tests use. The only issue is that I have no idea where it is, or where it may have dropped off (I don't think it was one of my commits). I'll try to track it down. |
Contributor
Author
|
Found it. The test is actually one of mine, it seems. I was probably using an asset from my own game, but didn't want to include it in the commit. |
It was left over from development and inevitably fails. TestGLTFUnlit serves as a good enough test anyway.
Contributor
Author
|
And, the fix is green. Sorry I didn't catch that earlier. |
stephengold
reviewed
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a GLTF loader extention that will allow jMonkeyEngine to use the Common/MatDefs/Misc/Unshaded.j3md material definition whenever a GLTF scene has the "unlit" material on an object. The branch contains a test environment for demonstration.
Note that in some other testing, I've noticed that the supposedly "unlit" material will be affected by shadows, which I did not notice when composing the scene in Blender. This appears to be due to jMonkey's shadows in particular, and not related to GLTF.
I first introduced it here. The thread mostly focuses on punctual lights, but I originally started on it for the unlit lights.