Add desaturation functionality to Unshaded.j3md #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a few lines of code for desaturating final color output based on a float value
added float variable "DesaturationValue" and corresponding define "DESATURATION" to support desaturation of the final output color in Unshaded.frag
fixed alpha value that was previously being set to 0.0 by mistake
Ali-RS
reviewed
Dec 19, 2020
added ifdef around variable declaration
Member
|
Actually, I was missing the point here. I read the code again, this can be merged. |
riccardobl
approved these changes
Dec 20, 2020
Ali-RS
reviewed
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a small amount of code to the Unshaded.j3md and Unshaded.frag files to allow for desaturating the material's output color based on a float value, specifically for use in GUIs.
Nearly all our GUI libraries use the Unshaded matdef for elements that are attached to the GUI node, and any custom gui elements will typically start from extending Unshaded if they need to do something in the shader, so adding this to Unshaded would alow all of our existent gui libraries to have desaturation functionality.
This should also not break any existing code, as nothing happens with this code unless the float value for desaturation gets defined for the material.
Following up on this thread https://hub.jmonkeyengine.org/t/how-to-desaturate-gui-element/43963