Added KHR_lights_punctual gltf extension #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Still having an issue with rotation on spot lights. |
Contributor
|
I have a fix for spotlight rotations, as I detail here. However, the fix is useful enough that I've suggested we may move it to a seperate PR. |
Merged
Contributor
Author
|
Currently blocked on #1466 |
Contributor
Author
|
#1466 was merged, I will update this ASAP. |
Contributor
Author
|
OK, I think this is ready for review. |
stephengold
reviewed
Mar 23, 2021
jme3-plugins/src/gltf/java/com/jme3/scene/plugins/gltf/LightsPunctualExtensionLoader.java
Outdated
Show resolved
Hide resolved
stephengold
reviewed
Mar 23, 2021
jme3-plugins/src/gltf/java/com/jme3/scene/plugins/gltf/LightsPunctualExtensionLoader.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the GLTF KHR_lights_punctual extension which allows lights from gltf files to be imported.
https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_lights_punctual
Please feel free to give feedback. I am currently looking for advice on implementing the intensity field from the gltf spec into the jme lights.
GLTF model taken from the KHR_light_punctual repo listed above.