Skip to content

resolve issue #1414 (checkSetParam warning while creating sky) #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephengold merged 1 commit into from
Dec 1, 2020
Merged

resolve issue #1414 (checkSetParam warning while creating sky) #1438

stephengold merged 1 commit into from
Dec 1, 2020

Conversation

@stephengold
Copy link
Member

@stephengold stephengold commented Nov 30, 2020

A solution using 2 different material definition assets:

  • "Common/MatDefs/Misc/Sky.j3md" for cube-mapped skies (tested using TestHoveringTank)
  • "Common/MatDefs/Misc/SkyNonCube.j3md" for sphere-mapped skies (tested using TestEverything) and equirect-mapped skies (tested using RefEnv)

@stephengold stephengold added this to the Future Release milestone Nov 30, 2020
danielperano
danielperano approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@danielperano danielperano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@stephengold stephengold merged commit d7a363c into jMonkeyEngine:master Dec 1, 2020
@stephengold stephengold deleted the sgold-issue-1414 branch December 1, 2020 19:39
@stephengold stephengold modified the milestones: Future Release, v3.4.0 Mar 13, 2021
@stephengold stephengold linked an issue Mar 16, 2021 that may be closed by this pull request
can't create sky from an EquirectMap without a warning #1414
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielperano danielperano danielperano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

can't create sky from an EquirectMap without a warning

2 participants

@stephengold @danielperano