Skip to content

Javadoc update, proposed fix for issue #1428 #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ali-RS merged 1 commit into from
Nov 18, 2020
Merged

Javadoc update, proposed fix for issue #1428 #1429

Ali-RS merged 1 commit into from
Nov 18, 2020

Conversation

@fredokun
Copy link
Contributor

@fredokun fredokun commented Nov 18, 2020

The terminate() method does not exist, the correct one is cleanup()

@stephengold
Copy link
Member

stephengold commented Nov 18, 2020

Looks good to me.

@Ali-RS
Copy link
Member

Ali-RS commented Nov 18, 2020

Thanks, @fredokun

@Ali-RS Ali-RS merged commit dce4d56 into jMonkeyEngine:master Nov 18, 2020
@Ali-RS Ali-RS mentioned this pull request Nov 18, 2020
Closed
@stephengold stephengold added this to the v3.4.0 milestone Mar 13, 2021
@stephengold stephengold added the Documentation Issues that affect the Wiki, Javadoc or any other form of documentation label Mar 13, 2021
@stephengold stephengold linked an issue Mar 16, 2021 that may be closed by this pull request
No terminate() method in BaseAppState #1428
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Documentation Issues that affect the Wiki, Javadoc or any other form of documentation

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

No terminate() method in BaseAppState

3 participants

@fredokun @stephengold @Ali-RS