-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding getters/setters to AnimComposer #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good to me. Thank you for your contribution to JMonkeyEngine! |
|
Small note: A proper title ( |
|
Can you please add documentation on those methods as well? |
Yes, will do. What is the policy in regards to authorship in source files? I'd change the class comment /**
* Created by Nehon on 20/12/2017.
*/to /**
* {@code AnimComposer} is a Spatial control that allows manipulation of
* armament (skeletal) animation.
*
* @author Nehon
* @since 20/12/2017.
*/ |
|
I have no idea about it, but I guess it might be better to do it in a separate PR. |
|
I'm not aware of any policy, only practice. Adding an "author" tag is fine. JMonkeyEngine usually does not use "since". Personally, I don't like seeing "code" tags in javadoc. The context usually makes them redundant. |
|
|
In regards to documentation: I tried to keep it close the the already existing one. If there's differing guide lines, I can of course overhaul the whole class ;-) |
|
Looks fine to me, thanks |
|
If there is no objection, I am going to merge this PR in next 24 hours. |
|
OK. Just remember to use "Squash and merge" instead of "Merge commit" please. |
Uh oh!
There was an error while loading. Please reload this page.