Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 8, 2020

No description provided.

@tlf30
Copy link
Contributor

tlf30 commented Apr 8, 2020

I think this PR can close #1092 and #796

@ghost
Copy link
Author

ghost commented Apr 8, 2020

I think this PR can close #1092 and #796

Sounds good!
I've been discussing it on the discord

@stephengold
Copy link
Member

stephengold commented Apr 11, 2020

At the moment, this PR seems very incomplete. It still needs to deal with AppSettings, JmeDesktopSystem, the build scripts, and the jme3-examples and jme3-jogl subprojects.

@ghost
Copy link
Author

ghost commented Apr 14, 2020

@stephengold , is anything specifically missing still in the AppSettings and JmeDesktopSystem classes?
The latest commits have removed jogl references, and the build scripts also seem to have all references to the jme3-jogl project removed.
As far as jme3-examples, I'll test the examples and make sure they are working fine.
And where are the jme3-jogl subprojects found at? This PR removes the jme3-jogl directory completely, so there is no longer anything inside it.

@stephengold
Copy link
Member

Wtf?? It seems I cloned the wrong branch: your "ItsMike54-rm_jogl" branch instead of your "rm_jogl" branch. I regret the confusion my error caused.

However, there are still references to JOGL in Java comments:

  • com.jme3.opencl.package_info.java
  • AppSettings.java
  • TestApplet.java
  • HelloOpenCL.java
  • TestContextSwitching.java
  • TestOpenCLLibraries.java
  • TestVertexBufferSharing.java
  • TestWriteToTexture.java
  • TestMultiPostWater.java

Now seems the right time to remove those.

@ghost
Copy link
Author

ghost commented Apr 15, 2020

Well that might confuse anybody. In meantime, I'll remove the references.
EDIT: Done, now let me build the project and fix any errors.

@tlf30
Copy link
Contributor

tlf30 commented Apr 15, 2020

@ItsMike54 both for the sanity of the ci system and my email, please group edits in as few as possible commits.

It is fine to make a couple extra commits when you realize you forgot something, but there is no need to have a commit for each change. All it does is re-trigger the ci build, and email everyone on the pr.

Thanks,
Trevor

@oxplay2
Copy link

oxplay2 commented Apr 15, 2020

10 people just receiving 10 emails: 👀

Please make single commits with multiple files Mike :) If you have any problem make commit with multiple file changes, then let us know.

@stephengold
Copy link
Member

Looks good. Integrating...

@stephengold stephengold merged commit 6c5611d into jMonkeyEngine:master Apr 15, 2020
@ghost ghost deleted the rm_jogl branch April 15, 2020 20:41
@ghost
Copy link
Author

ghost commented Aug 12, 2020

Lots of shit going on here after this PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants