-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove jogl #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jogl #1339
Conversation
|
At the moment, this PR seems very incomplete. It still needs to deal with |
|
@stephengold , is anything specifically missing still in the AppSettings and JmeDesktopSystem classes? |
|
Wtf?? It seems I cloned the wrong branch: your "ItsMike54-rm_jogl" branch instead of your "rm_jogl" branch. I regret the confusion my error caused. However, there are still references to JOGL in Java comments:
Now seems the right time to remove those. |
|
Well that might confuse anybody. In meantime, I'll remove the references. |
|
@ItsMike54 both for the sanity of the ci system and my email, please group edits in as few as possible commits. It is fine to make a couple extra commits when you realize you forgot something, but there is no need to have a commit for each change. All it does is re-trigger the ci build, and email everyone on the pr. Thanks, |
|
10 people just receiving 10 emails: 👀 Please make single commits with multiple files Mike :) If you have any problem make commit with multiple file changes, then let us know. |
|
Looks good. Integrating... |
|
Lots of shit going on here after this PR was merged |
No description provided.