Fixes #1261 - Clone the Terrain Picker, so that loading a terrain from file still works (after cloning, the picker would have the wrong terrain quad instance) #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a terrain from file still works (after cloning, the picker would have the wrong terrain quad instance)
Contributor
|
We can make it cloneable if anyone ever implements another picker type... I don't see that happening, though. At least now they will figure it out sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually mind the comment that has been removed.
Earlier versions had the picker init in collideWith(), to bypass this problem partially, but I think this is the best solution (apart from making Picker cloneable, but it doesn't preserve "much" state anyway).
So: This would be a fast fix for 3.3 (cherry picking) and we can think about cloning later.
Actually the code has been written like that to allow for multiple terrain picker algorithms, where currently we only have Bresenham.
What would need cloning, is the field
multipleCollisionsofBresenhamTerrainPicker, but since most cloning happens when loading, this isn't critical.Unless you prefer that we'd be doing things right right away and make the Picker Cloneable, for this I'd need guidance, though.