Skip to content

feat: add homebrew for easier installation#91

Merged
j05u3 merged 4 commits intomainfrom
homebrew
Oct 4, 2025
Merged

feat: add homebrew for easier installation#91
j05u3 merged 4 commits intomainfrom
homebrew

Conversation

@j05u3
Copy link
Copy Markdown
Owner

@j05u3 j05u3 commented Oct 4, 2025

This pull request updates the build and release workflow for the macOS app to improve reliability, support manual retries, and automate Homebrew tap updates. It also upgrades the Sparkle dependency to version 2.8.0 across the project.

Workflow enhancements:

  • Added manual trigger (workflow_dispatch) to .github/workflows/build-and-distribute.yml, allowing selective retry of build, Sparkle signing/release, and Homebrew tap update jobs, with input options for each step.
  • Improved artifact handling and version extraction logic to support both automatic and manual runs, including downloading artifacts from existing releases for retries. [1] [2]

Homebrew tap automation:

  • Introduced a new update-homebrew-tap job that automatically creates or updates the Homebrew cask file and pushes changes to the j05u3/homebrew-tap repository after a successful release.

Dependency upgrades:

  • Updated Sparkle dependency to version 2.8.0 in Package.swift, Xcode project file (VTSApp.xcodeproj/project.pbxproj), and related setup scripts. [1] [2] [3]

Tooling update:

  • Updated Sparkle tools download logic in the workflow and setup scripts to use the new version. [1] [2]

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @j05u3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the Sparkle framework dependency to its latest stable version, 2.8.0. This update ensures the application leverages the most recent enhancements, bug fixes, and security patches from the Sparkle project, contributing to improved stability and user experience for software updates. It's worth noting that while the PR title mentions "add homebrew for easier installation", the provided changes exclusively pertain to the Sparkle dependency update.

Highlights

  • Sparkle Framework Update: The Sparkle framework, responsible for software updates, has been upgraded from version 2.7.1 to 2.8.0 across various project configuration files and scripts.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build-and-distribute.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Sparkle dependency from version 2.7.1 to 2.8.0. The version bump is applied consistently across Package.swift, Package.resolved, the Xcode project file, and the setup-sparkle.sh script.

While the changes themselves are correct, the pull request title 'feat: add homebrew for easier installation' appears to be mismatched with the content, which is a dependency update. It would be beneficial to update the title to accurately reflect the changes for better clarity in the project's history.

I've added one suggestion in scripts/setup-sparkle.sh to improve maintainability by centralizing the version number, which will make future updates easier.

# Create a temporary directory for Sparkle tools
TEMP_DIR=$(mktemp -d)
SPARKLE_VERSION="2.7.1"
SPARKLE_VERSION="2.8.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid having to update the version number in multiple places, consider reading the Sparkle version directly from Package.swift. This would create a single source of truth for the version and prevent potential inconsistencies in the future.

For example, you could replace this line with:

SPARKLE_VERSION=$(awk -F'\"' '/sparkle-project\/Sparkle/ {print $4}' Package.swift)

This ensures that the script always uses the same version as defined in your Swift package dependencies.

Suggested change
SPARKLE_VERSION="2.8.0"
SPARKLE_VERSION=$(awk -F'"' '/sparkle-project\/Sparkle/ {print $4}' Package.swift)

@j05u3 j05u3 merged commit d3cfbf6 into main Oct 4, 2025
2 checks passed
@j05u3 j05u3 deleted the homebrew branch October 4, 2025 07:03
@j05u3 j05u3 mentioned this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant