-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: support epd_waveshare #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Heya! |
Absolutely. I'll tackle that tonight. On a related note I kind of want to change the implementation of EDIT: I also just saw that epd-waveshare implements it the other way around for |
|
Hi! I would prefer for |
Thanks for the feedback, I understand that. I updated the README. Let me know if I should add anything else. |
j-g00da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Code looks good, but I don't really have hardware to test this.
If you can, it would be nice to add a minimal example project in /examples using your hardware.
Co-authored-by: Jagoda Estera Ślązak <[email protected]>
Yeah, so that is kinda complicated, since I had to make a couple of changes across multiple crates (mousefood, ratatui, kasuari) to get all of this working on the Raspberry Pi Pico. |
|
Not a problem :) |
|
Btw. Do you have a picture of mousefood/ratatui running on waveshare EPD? |
|
I can take one. Should I add it to the README then? BTW I should be able to include the example tomorrow, the esp32 I ordered should arrive then. |
|
Sounds great! Yeah it would be nice to include it in the README.md. I'm also giving a talk about ratatui and mousefood this friday and would happily include it in the slideshow. |
|
I tried to quickly throw together an example using an esp32c6, but I unfortunately run into that issue here. So sorry that I am not able to provide you with another image for your presentation tomorrow. |
|
So I added an example using a xtensa board. |
j-g00da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just few minor things :)
4f59492 to
9d73778
Compare
2991d9d to
7b8e221
Compare
|
I applied your suggested changes |
Hello there,
I tried to run mousefood on a waveshare display, since it was lacking support I tried my best to add it.
It works fine on my project using a Raspberry Pi Pico and a waveshare epd 2by9.
Kind regards