Skip to content

Conversation

@jmurty
Copy link
Contributor

@jmurty jmurty commented Nov 12, 2019

Update the transcrypt encryption utility to be
based on upstream's version 1.1.0 but also with
new features from our IC fork:

Script sourced from
ixc/transcrypt@e9e1d96c

Update the `transcrypt` encryption utility to be
based on upstream's version 1.1.0 but also with
new features from our IC fork:

- on init, add a merge driver to properly handle
  merge of secrets files with conflicting changes:
  ixc/transcrypt#1
  The .gitattributes file is also adjusted to
  apply the merge driver.
- on init, add a Git pre-commit hook script to
  abort commit if raw content of a secrets file
  is not properly encrypted:
  ixc/transcrypt#2
- cherry-picked upstream fix to silence spurious
  warnings:
  github.com/elasticdog/transcrypt/commit/9a8a1f

Script sourced from
ixc/transcrypt@e9e1d96c
@jmurty
Copy link
Contributor Author

jmurty commented Nov 12, 2019

Hi @Aramgutang and @mrmachine these IC-specific improvements to transcrypt have been working okay in AGSA for a little while now, and solve a couple of big problems with the tool.

But since this involves both encryption and git magic – both things very easy to stuff up – it would benefit from some review or testing before we start rolling it out to future sites or upgraded sites.

@Aramgutang
Copy link
Member

I don't think I have the domain knowledge to provide useful feedback, I'm afraid.

@jmurty
Copy link
Contributor Author

jmurty commented Nov 12, 2019

@Aramgutang if you're keen you could follow the reproduction steps in that Stack Overflow question to compare results of the old or new scripts, but no problem if you're not so keen

@Aramgutang
Copy link
Member

I don't use go.sh locally and I rely on my system installation of transcrypt, so reproducing the scenario would take a bunch of extra steps for me. I'm happy with having to wrangle merge conflicts in secrets files manually, if they happen to me.

Update the `transcrypt` encryption utility with
latest fix for merging of encrypted files from
our IC fork.

The script is from https://github.com/ixc/ at 31c63750
@jmurty
Copy link
Contributor Author

jmurty commented May 22, 2020

This PR was made redundant by f3c2daf

@jmurty jmurty closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants