Skip to content

Refactor zirc.event.Event #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2016
Merged

Refactor zirc.event.Event #29

merged 1 commit into from
Dec 9, 2016

Conversation

@BradleyShaw
Copy link
Contributor

@BradleyShaw BradleyShaw commented Dec 9, 2016

This removes the need for special parsing based on event type.

NB: for NICK, the new nick will be event.arguments[0] rather than event.target

@wolfy1339 wolfy1339 merged commit e052fc1 into itslukej:master Dec 9, 2016
@wolfy1339 wolfy1339 added this to the v1.2.5 milestone Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v1.2.5

Development

Successfully merging this pull request may close these issues.

2 participants

@BradleyShaw @wolfy1339