chore(rpc): optimize wallet_getAssets balance fetching
#1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mablr
commented
Oct 29, 2025
mattsse
reviewed
Oct 29, 2025
src/rpc/relay.rs
Outdated
Comment on lines
2760
to
2764
| let mut multicall = chain_provider.multicall().dynamic(); | ||
| for address in &erc20_addresses { | ||
| let erc20 = IERC20::new(address.address(), &chain_provider); | ||
| multicall = multicall.add_dynamic(erc20.balanceOf(request.account)); | ||
| } |
Member
There was a problem hiding this comment.
I think this is basically
chain_provider.multicall().dynamic().extend(...);
then we can shorten this entire section a bit
Contributor
Author
There was a problem hiding this comment.
I just applied the change.
This is more idiomatic, but not significantly shorter.😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1498
Batching
balanceOfcall for erc20 assets