Skip to content

Use dockerx #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
istio-testing merged 1 commit into from
Mar 5, 2020
Merged

Use dockerx #575

istio-testing merged 1 commit into from
Mar 5, 2020

Conversation

@howardjohn
Copy link
Member

@howardjohn howardjohn commented Nov 25, 2019

No description provided.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Nov 25, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 25, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2019
@howardjohn
Copy link
Member Author

howardjohn commented Nov 26, 2019

/test all

@howardjohn
Copy link
Member Author

howardjohn commented Nov 26, 2019

/retest

@howardjohn
Copy link
Member Author

howardjohn commented Nov 26, 2019

not sure why this fails, should work according to moby/buildkit#1159

@howardjohn
Copy link
Member Author

howardjohn commented Dec 17, 2019

/retest

@howardjohn howardjohn mentioned this pull request Dec 20, 2019
Closed
@howardjohn
Copy link
Member Author

howardjohn commented Jan 16, 2020

Closing until moby/buildkit#1298 is fixed/I find out why it fails

@howardjohn howardjohn closed this Jan 16, 2020
@howardjohn howardjohn reopened this Mar 5, 2020
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Mar 5, 2020
@howardjohn
Copy link
Member Author

howardjohn commented Mar 5, 2020

open

@howardjohn howardjohn reopened this Mar 5, 2020
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 5, 2020
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 5, 2020
@howardjohn
Copy link
Member Author

howardjohn commented Mar 5, 2020

build time from 33min -> 13min

@howardjohn howardjohn marked this pull request as ready for review March 5, 2020 17:15
@howardjohn howardjohn requested a review from a team as a code owner March 5, 2020 17:15
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 5, 2020
@howardjohn howardjohn added do-not-merge Block automatic merging of a PR. and removed do-not-merge Block automatic merging of a PR. labels Mar 5, 2020
@istio-testing istio-testing merged commit fc9a6ce into istio:master Mar 5, 2020
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jun 30, 2022
@istio-testing @howardjohn
Use dockerx (istio#575)
a3b4dbd 
Co-authored-by: howardjohn <[email protected]>
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jul 6, 2022
@istio-testing @howardjohn
Use dockerx (istio#575)
bb9d1ac 
Co-authored-by: howardjohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nmittler nmittler nmittler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericvn ericvn

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@howardjohn @nmittler @googlebot @ericvn @istio-testing @istio-policy-bot