Skip to content

remove hide_from_docs for http route mirrors #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023
Merged

remove hide_from_docs for http route mirrors #2893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions kubernetes/customresourcedefinitions.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions networking/v1alpha3/virtual_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

64 changes: 63 additions & 1 deletion networking/v1alpha3/virtual_service.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions networking/v1alpha3/virtual_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,9 +633,6 @@ message HTTPRoute {
// destination.
Destination mirror = 9;

// $hide_from_docs
// Hide this from doc until implemented.
//
// Specifies the destinations to mirror HTTP traffic in addition
// to the original destination. Mirrored traffic is on a
// best effort basis where the sidecar/gateway will not wait for the
Expand Down Expand Up @@ -2090,25 +2087,16 @@ message HTTPFaultInjection {
}
}

// $hide_from_docs
// Hide this from doc until implemented.
//
// HTTPMirrorPolicy can be used to specify the destinations to mirror HTTP traffic in addition
// to the original destination. Mirrored traffic is on a
// best effort basis where the sidecar/gateway will not wait for the
// mirrored destinations to respond before returning the response from the
// original destination. Statistics will be generated for the mirrored
// destination.
message HTTPMirrorPolicy {
// $hide_from_docs
// Hide this from doc until implemented.
//
// Destination specifies the target of the mirror operation.
Destination destination = 1 [(google.api.field_behavior) = REQUIRED];

// $hide_from_docs
// Hide this from doc until implemented.
//
// Percentage of the traffic to be mirrored by the `destination` field.
// If this field is absent, all the traffic (100%) will be mirrored.
// Max value is 100.
Expand Down
12 changes: 0 additions & 12 deletions networking/v1beta1/virtual_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions networking/v1beta1/virtual_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,9 +633,6 @@ message HTTPRoute {
// destination.
Destination mirror = 9;

// $hide_from_docs
// Hide this from doc until implemented.
//
// Specifies the destinations to mirror HTTP traffic in addition
// to the original destination. Mirrored traffic is on a
// best effort basis where the sidecar/gateway will not wait for the
Expand Down Expand Up @@ -2090,25 +2087,16 @@ message HTTPFaultInjection {
}
}

// $hide_from_docs
// Hide this from doc until implemented.
//
// HTTPMirrorPolicy can be used to specify the destinations to mirror HTTP traffic in addition
// to the original destination. Mirrored traffic is on a
// best effort basis where the sidecar/gateway will not wait for the
// mirrored destinations to respond before returning the response from the
// original destination. Statistics will be generated for the mirrored
// destination.
message HTTPMirrorPolicy {
// $hide_from_docs
// Hide this from doc until implemented.
//
// Destination specifies the target of the mirror operation.
Destination destination = 1 [(google.api.field_behavior) = REQUIRED];

// $hide_from_docs
// Hide this from doc until implemented.
//
// Percentage of the traffic to be mirrored by the `destination` field.
// If this field is absent, all the traffic (100%) will be mirrored.
// Max value is 100.
Expand Down