virtual service supports traffic mirroring to multiple destinations #2805
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
😊 Welcome @fatedier! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/M
fatedier
added
the
release-notes-none
|
/test release-notes |
howardjohn
left a comment
howardjohn
left a comment
There was a problem hiding this comment.
Mostly lgtm. I want to check gateway-api plans though: (https://kubernetes.slack.com/archives/CR0H13KGA/p1686580503265289) for alignment
|
Will be good to resolve kubernetes-sigs/gateway-api#2109 first |
|
Is there an implementation for this? If not, should we hide the API docs first? |
I am not very familiar with the process. First, I would like to confirm if modifying this API is acceptable, and then proceed with its implementation. |
|
lin means there should be a following implement in istio, otherwise mark it hidden |
istio-testing
added
size/L
|
Hide from docs done. |
|
@howardjohn Hi, I found that kubernetes-sigs/gateway-api#2109 has been accepted. Can the modifications to this API continue to progress? |
"Accepted" does not mean approved, it just means it was acknowledged by the maintainers. |
|
Looks like GW is going to approve, just waiting on official signoff then will approve this. Thanks for the patience |
|
May I ask if you know how much time after the merge we'll have to wait for this feature to be included in any Istio release? |
There is already a draft PR in istio repo istio/istio#45944. I believe that after the modification of the API is merged, the implementation of this feature will not take too long. |
|
/easycla |
8 participants
Fix: istio/istio#13330