fix: Drop coverage produced by nyc --all for files that were tested
#1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the coverage data produced by `nyc --all` is incompatible with the coverage data produced by actual test runs. This is generally due to configuration error but results in inconsistent coverage reports or in some cases causes `nyc report` to crash. The workaround is implemented in istanbul-lib-coverage to drop coverage data associated with `nyc --all` when coverage data from a test run is found. This commit tags the coverage data when appropriate so the coverage merge logic knows what to do. Fixes istanbuljs#1113, istanbuljs#1124, istanbuljs#1148
This makes the behavior consistent with the real instrumenter which just provides raw data.
bcoe
approved these changes
Aug 1, 2019
1 task
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the coverage data produced by
nyc --allis incompatible withthe coverage data produced by actual test runs. This is generally due
to configuration error but results in inconsistent coverage reports or
in some cases causes
nyc reportto crash. The workaround isimplemented in istanbul-lib-coverage to drop coverage data associated
with
nyc --allwhen coverage data from a test run is found. Thiscommit tags the coverage data when appropriate so the coverage merge
logic knows what to do.
Fixes #1113, #1124, #1148