-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Improve documentation #6307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation #6307
Changes from 14 commits
2e8ee6d
86e7a2f
3ea347d
381882d
17a27a3
0b8edfd
201b6bd
5d798fd
42a1106
4c48feb
9af3bdc
d71cd20
9c956d2
fb7c71c
c99fd1b
af3ba12
04d8799
3d82438
549c739
0d675cd
a3cbf05
e807806
cfd570f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,12 +27,11 @@ | |
| # import sys | ||
| # sys.path.insert(0, os.path.abspath('.')) | ||
|
|
||
| import sys | ||
| import os | ||
| import re | ||
| import subprocess | ||
| from pathlib import Path | ||
| import shutil | ||
| import sys | ||
| from typing import List | ||
|
|
||
|
|
||
| def get_git_short_hash(): | ||
|
|
@@ -120,7 +119,15 @@ def get_git_short_hash(): | |
| # List of patterns, relative to source directory, that match files and | ||
| # directories to ignore when looking for source files. | ||
| # This patterns also effect to html_static_path and html_extra_path | ||
| exclude_patterns = ["_build", "Thumbs.db", ".DS_Store", "**.ipynb_checkpoints"] | ||
| exclude_patterns = [ | ||
| "_build", | ||
| "Thumbs.db", | ||
| ".DS_Store", | ||
| "**.ipynb_checkpoints", | ||
| "docker.in.rst", | ||
| "getting_started.in.rst", | ||
| "jupyter/*/*.ipynb", | ||
| ] | ||
|
|
||
| # The name of the Pygments (syntax highlighting) style to use. | ||
| pygments_style = "sphinx" | ||
|
|
@@ -264,8 +271,22 @@ def skip(app, what, name, obj, would_skip, options): | |
| return would_skip | ||
|
|
||
|
|
||
| def escape_vertical_bars(app, what, name, obj, options, lines: List[str]): | ||
| # Note - Latex docs also contains Vertical Bar, so we | ||
| # apply this filtering only to specific classes. | ||
| if name in [ | ||
| "open3d.data.RedwoodIndoorLivingRoom1", | ||
| "open3d.data.RedwoodIndoorLivingRoom2", | ||
| "open3d.data.RedwoodIndoorOffice1", | ||
| "open3d.data.RedwoodIndoorOffice2", | ||
| ]: | ||
| for index in range(len(lines)): | ||
| lines[index] = lines[index].replace("|", "\|") | ||
|
|
||
|
|
||
| def setup(app): | ||
| app.connect("autodoc-skip-member", skip) | ||
| app.connect("autodoc-process-docstring", escape_vertical_bars) | ||
|
||
| # Add Google analytics | ||
| app.add_js_file("https://www.googletagmanager.com/gtag/js?id=G-3TQPKGV6Z3", | ||
| **{'async': 'async'}) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,7 +100,7 @@ install the latest development version directly with pip: | |
|
|
||
| .. code-block:: bash | ||
|
|
||
| pip install --trusted-host www.open3d.org -f http://www.open3d.org/docs/latest/getting_started.html open3d | ||
| pip install -U --trusted-host www.open3d.org -f http://www.open3d.org/docs/latest/getting_started.html open3d | ||
saurabheights marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| .. note:: | ||
| The development wheels for Linux are named according to PEP600. Please | ||
|
|
@@ -144,9 +144,7 @@ demonstrate the usage of Open3D Python interface. See ``examples/python`` for | |
| all Python examples. | ||
|
|
||
| .. note:: Open3D's Python tutorial utilizes some external packages: ``numpy``, | ||
| ``matplotlib``, ``opencv-python``. OpenCV is only used for reconstruction | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed missing shell script, as well as why Opencv is used (most users dont care about that) and also its easy to make this doc redundant when adding a new example where opencv is used (which might have already happened, I do need to check if |
||
| system. Please read ``util/install-deps-python.sh`` for installing these | ||
| packages. | ||
| ``matplotlib``, ``opencv-python``. | ||
|
|
||
| .. _install_open3d_c++: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,9 +26,9 @@ Open3D: A Modern Library for 3D Data Processing | |
| compilation | ||
| cpp_project | ||
| builddocs | ||
| open3d_ml | ||
| arm | ||
| docker | ||
| arm | ||
| open3d_ml | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I moved open3d_ml to the bottom and arm above, with docker option closer to right after compilation, since new user would want to see how to get started with open3d faster. Let me know if this is alright or not. |
||
|
|
||
| .. toctree:: | ||
| :maxdepth: 2 | ||
|
|
@@ -46,23 +46,6 @@ Open3D: A Modern Library for 3D Data Processing | |
| tutorial/sensor/index | ||
| tutorial/reference | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
| :caption: Contribute | ||
|
|
||
| contribute/contribute | ||
| contribute/contribution_recipes | ||
| contribute/styleguide | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
| :caption: C++ API | ||
|
|
||
| cpp_api | ||
|
|
||
| .. | ||
| Note: when adding new modules, please also update documented_modules.txt. | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
| :caption: Python API | ||
|
|
@@ -88,3 +71,20 @@ Open3D: A Modern Library for 3D Data Processing | |
| python_example/pipelines/index | ||
| python_example/utility/index | ||
| python_example/visualization/index | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
| :caption: C++ API | ||
|
|
||
| cpp_api | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
| :caption: Contribute | ||
|
|
||
| contribute/contribute | ||
| contribute/contribution_recipes | ||
| contribute/styleguide | ||
|
|
||
| .. | ||
| Note: when adding new modules, please also update documented_modules.txt. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -405,7 +405,7 @@ | |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "#### 1. Set Inputs and Parameters" | ||
| "### 1. Set Inputs and Parameters" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More info on why here - spatialaudio/nbsphinx#373 (comment) P.S. Just noticed that the changes here are getting over written somehow when building docs. Will check and fix this commit.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Found my oversight. So, changes here are getting ignored because a pre-built Is the documentation still built without cuda on CI/CD?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think so. It is safe to keep the changes here now, we can study the best option regarding large notebook files in another PR. |
||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -453,7 +453,7 @@ | |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "#### 2. Get Registration Result from ICP" | ||
| "### 2. Get Registration Result from ICP" | ||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -602,7 +602,7 @@ | |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "#### 1. Set Inputs and Parameters" | ||
| "### 1. Set Inputs and Parameters" | ||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -656,7 +656,7 @@ | |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "#### 2. Get Registration Result from Multi-Scale ICP" | ||
| "### 2. Get Registration Result from Multi-Scale ICP" | ||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -884,7 +884,7 @@ | |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "#### 1. Set Inputs and Parameters" | ||
| "### 1. Set Inputs and Parameters" | ||
| ] | ||
| }, | ||
| { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Geometry (Tensor) | ||
| ======== | ||
| ================= | ||
|
|
||
| .. toctree:: | ||
| :caption: Basics | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| .. _t_pipelines: | ||
|
|
||
| Pipelines (Tensor) | ||
| ========= | ||
| ================== | ||
|
|
||
| .. toctree:: | ||
|
|
||
|
|
||



Uh oh!
There was an error while loading. Please reload this page.