Removing redundant checks #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When we are comparing the `objectToString` values, `isObject` check is not necessary. So removing those checks. 2. `Buffer.isArray` and `Array.isArray` need not be run in another function, as they are static functions.
Contributor
Author
|
Bump! |
Contributor
Author
|
@isaacs Bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objectToStringvalues,isObjectcheck is notnecessary. So removing those checks. Refer util: removing redundant checks in is* functions nodejs/node#2179
Buffer.isArrayneed not be run in another function, as it is a static function.