Skip to content

Handle EISDIR from lchown in node <10.6 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isaacs merged 3 commits into from
Jul 3, 2019
Merged

Handle EISDIR from lchown in node <10.6 #21

isaacs merged 3 commits into from
Jul 3, 2019

Conversation

@isaacs
Copy link
Owner

@isaacs isaacs commented Jul 3, 2019

Fix #20

@coveralls
Copy link

coveralls commented Jul 3, 2019

Coverage Status

Coverage increased (+9.9%) to 87.5% when pulling 233e197 on handle-eisdir into 7a5c3d5 on master.

@coveralls
Copy link

coveralls commented Jul 3, 2019 •
edited
Loading

Coverage Status

Coverage increased (+8.2%) to 85.714% when pulling d3e5d3f on handle-eisdir into 7a5c3d5 on master.

@isaacs isaacs changed the title Handle EISDIR from lchown in node v8 Handle EISDIR from lchown in node <10.6 Jul 3, 2019
@isaacs isaacs force-pushed the handle-eisdir branch 2 times, most recently from f318a5e to ee47a66 Compare July 3, 2019 21:25
isaacs added 2 commits July 3, 2019 14:31
@isaacs
Remove fundamentally broken symlink tests
32723fe 
These tests depend on being able to lchown a symbolic link to /bin/sh,
and rely on the assumption that /bin/sh is not owned by the current
user.

The first assumption will typically fail on Linux whenever the second
assumption is true!

Fixing the first, by linking to a local file instead, means that the
second is violated.

There is no way to save these tests, so they are being removed.
@isaacs
.travis version update
da434c3
@isaacs isaacs merged commit da434c3 into master Jul 3, 2019
isaacs added a commit to npm/cli that referenced this pull request Jul 3, 2019
@isaacs
[email protected]
f6164d5 
This handles an EISDIR error from cacache on Darwin in Node versions
prior to 10.6.

Fix: [npm.community#7901](https://npm.community/t/7901/)
Fix: [npm.community#8203](https://npm.community/t/8203/)
Fix: isaacs/chownr#20
PR-URL: isaacs/chownr#21
This was referenced Aug 13, 2019
Open
Merged
This was referenced Aug 30, 2019
Open
Open
Merged
@Omrisnyk Omrisnyk mentioned this pull request Apr 30, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EISDIR error when invoked from cacache under sudo to fix ownership on MacOS

3 participants

@isaacs @coveralls