Skip to content

Conversation

@mingxin-zheng
Copy link
Contributor

Fixes #ISSUE_NUMBER

Description

@mingxin-zheng mingxin-zheng requested a review from Nic-Ma March 25, 2025 04:07
@mingxin-zheng
Copy link
Contributor Author

mingxin-zheng commented Mar 25, 2025

Example run:

python tools/run_all_tests.py --integration
Looking for tests in workflows/robotic_ultrasound/tests
Running integration test: workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py
Sending SIGINT after 120 seconds...
2025-03-25 03:30:26 [114,443ms] [Warning] [omni.usd] Unexpected reference count of 3 for UsdStage 'anon:0x13e0fd90:World0.usd' while being closed in UsdContext (this may indicate it is still resident in memory).
[INFO]: Simulation is stopped. Shutting down the app.



.
----------------------------------------------------------------------
Ran 1 test in 123.015s

OK

All tests passed

mingxin-zheng and others added 4 commits March 31, 2025 21:39
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng mingxin-zheng requested a review from Copilot March 31, 2025 16:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces integration tests for the robotic ultrasound workflow and adjusts related scripts to support integration testing. Key changes include:

  • Addition of a new integration test file for simulation evaluation.
  • Updates to the evaluation script with modified defaults and an added output message.
  • Enhancements to the test runner script to separately handle integration tests.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py New integration test implementation for simulation evaluation with process monitoring.
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/pi0_policy/eval.py Modified default argument values and added an output message to signal environment reset.
workflows/robotic_ultrasound/scripts/simulation/README.md Updated command example to reflect the new defaults.
tools/run_all_tests.py Enhanced test discovery and execution logic, including segregation of integration tests.

@mingxin-zheng
Copy link
Contributor Author

Test output:

$ python tools/run_all_tests.py --integration
Looking for tests in workflows/robotic_ultrasound/tests
Running test: workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py
Sending SIGINT after 120 seconds...
2025-03-31 16:28:40 [113,732ms] [Warning] [omni.usd] Unexpected reference count of 3 for UsdStage 'anon:0x1914e650:World0.usd' while being closed in UsdContext (this may indicate it is still resident in memory).
[INFO]: Simulation is stopped. Shutting down the app.


.
----------------------------------------------------------------------
Ran 1 test in 123.622s

OK

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for the quick update.

Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng mingxin-zheng enabled auto-merge (squash) April 1, 2025 02:56
@mingxin-zheng mingxin-zheng merged commit 9eedd2d into main Apr 1, 2025
3 checks passed
@mingxin-zheng mingxin-zheng deleted the mz/integration_test branch April 2, 2025 01:15
mingxin-zheng added a commit that referenced this pull request Apr 16, 2025
Fixes #ISSUE_NUMBER

---------

Signed-off-by: Mingxin Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants