-
Notifications
You must be signed in to change notification settings - Fork 5
[CI] Add integration test for robotic ultrasound workflow #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
|
Example run: python tools/run_all_tests.py --integration
Looking for tests in workflows/robotic_ultrasound/tests
Running integration test: workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py
Sending SIGINT after 120 seconds...
2025-03-25 03:30:26 [114,443ms] [Warning] [omni.usd] Unexpected reference count of 3 for UsdStage 'anon:0x13e0fd90:World0.usd' while being closed in UsdContext (this may indicate it is still resident in memory).
[INFO]: Simulation is stopped. Shutting down the app.
.
----------------------------------------------------------------------
Ran 1 test in 123.015s
OK
All tests passed
|
workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces integration tests for the robotic ultrasound workflow and adjusts related scripts to support integration testing. Key changes include:
- Addition of a new integration test file for simulation evaluation.
- Updates to the evaluation script with modified defaults and an added output message.
- Enhancements to the test runner script to separately handle integration tests.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py | New integration test implementation for simulation evaluation with process monitoring. |
| workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/pi0_policy/eval.py | Modified default argument values and added an output message to signal environment reset. |
| workflows/robotic_ultrasound/scripts/simulation/README.md | Updated command example to reflect the new defaults. |
| tools/run_all_tests.py | Enhanced test discovery and execution logic, including segregation of integration tests. |
|
Test output: $ python tools/run_all_tests.py --integration
Looking for tests in workflows/robotic_ultrasound/tests
Running test: workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py
Sending SIGINT after 120 seconds...
2025-03-31 16:28:40 [113,732ms] [Warning] [omni.usd] Unexpected reference count of 3 for UsdStage 'anon:0x1914e650:World0.usd' while being closed in UsdContext (this may indicate it is still resident in memory).
[INFO]: Simulation is stopped. Shutting down the app.
.
----------------------------------------------------------------------
Ran 1 test in 123.622s
OK |
workflows/robotic_ultrasound/tests/test_simulation/test_integration_eval.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for the quick update.
Signed-off-by: Mingxin Zheng <[email protected]>
Fixes #ISSUE_NUMBER --------- Signed-off-by: Mingxin Zheng <[email protected]>
Fixes #ISSUE_NUMBER
Description