Update Dependency Tags to 0.2.0 and Remove SSH Token Use #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
mingxin-zheng
requested review from
KumoLiu,
Nic-Ma,
SachidanandAlle,
mocsharp and
wendell-hom
Signed-off-by: Mingxin Zheng <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes dependency on SSH tokens across Docker builds and run scripts, switches repository and package installations to HTTPS, and adds automated Raysim installation.
- Removed
--ssh, SSH client installation, and related SSH setup in Dockerfiles and run scripts. - Updated
pip installandgit clonecommands to use HTTPS URLs. - Introduced
install_raysim.shand integrated it into the ultrasound environment setup.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/telesurgery/docker/sim.sh | Removed SSH mount and --ssh build flag. |
| workflows/telesurgery/docker/real.sh | Removed SSH mount and --ssh build flag. |
| workflows/telesurgery/docker/Dockerfile.sim | Dropped openssh-client, SSH host scan, and SSH-based pip install. |
| workflows/telesurgery/docker/Dockerfile | Dropped openssh-client and SSH host scan. |
| workflows/telesurgery/README.md | Removed SSH agent instructions. |
| workflows/robotic_ultrasound/docker/README.md | Removed BuildKit/SSH instructions and --ssh build flag. |
| workflows/robotic_ultrasound/docker/Dockerfile | Removed SSH host setup and SSH mount in RUN mounts. |
| workflows/robotic_ultrasound/README.md | Streamlined Raysim installation instructions. |
| workflows/robotic_surgery/docker/README.md | Removed BuildKit/SSH instructions and --ssh build flag. |
| workflows/robotic_surgery/docker/Dockerfile | Removed SSH host setup and SSH mount in RUN mounts. |
| tools/env_setup/env_setup_robot_us.sh | Added unzip installation and integrated Raysim setup. |
| tools/env_setup/install_raysim.sh | New script for downloading and installing Raysim. |
| tools/env_setup/install_isaac.sh | Switched asset catalog pip install and cloning to HTTPS. |
| tools/env_setup/install_cosmos_transfer1.sh | Switched cloning to HTTPS. |
Signed-off-by: Mingxin Zheng <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Mingxin Zheng <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Mingxin Zheng <[email protected]>
KumoLiu
approved these changes
Jul 14, 2025
|
/build |
Signed-off-by: Mingxin Zheng <[email protected]>
|
/build |
mingxin-zheng
changed the title
Signed-off-by: Mingxin Zheng <[email protected]>
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes dependency on SSH tokens across Docker builds and run scripts, switches repository and package installations to HTTPS, and adds automated Raysim installation.