-
Notifications
You must be signed in to change notification settings - Fork 5
Refactoring of the robotic surgery documentation to break out subfolders into focused READMEs #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A refactoring of the robotic surgery documentation to break out subfolders into focused READMEs, simplify navigation, and enhance clarity with a technical overview and quick start.
- Introduces dedicated
README.mdfiles for Reinforcement Learning and State Machine environments. - Simplifies the simulation folder index and updates Docker instructions.
- Overhauls the top-level workflow README with emojis, a quick-start guide, and structured setup details.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/robotic_surgery/scripts/simulation/scripts/reinforcement_learning/rsl_rl/README.md | New RL training and play instructions |
| workflows/robotic_surgery/scripts/simulation/scripts/environments/state_machine/README.md | New state-machine usage examples |
| workflows/robotic_surgery/scripts/simulation/README.md | Simplified simulation folder index |
| workflows/robotic_surgery/docker/README.md | Clarified interactive and headless Docker commands |
| workflows/robotic_surgery/README.md | Major restructure: tech overview, quick start, TOC |
Comments suppressed due to low confidence (3)
workflows/robotic_surgery/scripts/simulation/README.md:4
- [nitpick] Consider adding a brief description for each link to guide users—for example:
- [State Machine Environments](./scripts/environments/state_machine/README.md): examples of hand-crafted surgical state machines.
- [State Machine Environments](./scripts/environments/state_machine/README.md)
workflows/robotic_surgery/README.md:23
- The anchor link may not resolve correctly due to the leading hyphen. Update it to
(#running-workflows)or test the actual generated ID to ensure the TOC link works.
- [⚡ Running Workflows](#-running-workflows)
workflows/robotic_surgery/scripts/simulation/scripts/reinforcement_learning/rsl_rl/README.md:12
- The docs mention "playing with 50 environments" but the example command lacks a
--num-envsflag. Either clarify the default behavior or include the flag (e.g.,--num-envs 50) in the example.
# run script for playing with 50 environments
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
6fbe84e to
5822eda
Compare
|
/build |
Signed-off-by: Mingxin Zheng <[email protected]>
|
/build |
A refactoring of the robotic surgery documentation to break out subfolders into focused READMEs, simplify navigation, and enhance clarity with a technical overview and quick start.
Introduces dedicated README.md files for Reinforcement Learning and State Machine environments.
Simplifies the simulation folder index and updates Docker instructions.
Overhauls the top-level workflow README with emojis, a quick-start guide, and structured setup details.