Pin the Isaac-GR00T repository to the n1-release branch and update related documentation and setup scripts #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
|
/build |
1 similar comment
|
/build |
Signed-off-by: YunLiu <[email protected]>
|
/build |
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
|
/build |
2 similar comments
|
/build |
|
/build |
Signed-off-by: YunLiu <[email protected]>
|
/build |
mingxin-zheng
approved these changes
Jul 1, 2025
|
Thanks for the update and fix! |
There was a problem hiding this comment.
Pull Request Overview
This PR pins the Isaac-GR00T repository to the n1-release branch and updates related documentation and setup scripts.
- Updated the replay recording command to include camera enablement and refined Cosmos-Transfer instructions
- Revised tutorial links to version-specific URDF import docs and added a new OpenXR tutorial entry
- Adjusted environment setup scripts: split
apt-getcommands, added branch checkout for GR00T, and updated pip installs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/robotic_ultrasound/scripts/simulation/README.md | Refined replay_recording invocation and Cosmos-Transfer notes |
| tutorials/assets/bring_your_own_robot/replace_franka_hand_with_ultrasound_probe.md | Versioned URDF import documentation links to v4.5.0 |
| tutorials/assets/README.md | Added new “Bring Your Own Head-Mounted Display with OpenXR” entry |
| tools/env_setup_robot_us.sh | Separated and reordered apt-get update/install commands |
| tools/env_setup/install_gr00tn1.sh | Checked out n1-release, switched to pip install -e .[base], pinned transformers |
Comments suppressed due to low confidence (2)
workflows/robotic_ultrasound/scripts/simulation/README.md:191
- The CLI invocation now omits the --hdf5_path flag; please confirm that replay_recording.py has been updated to accept the HDF5 path as a positional argument, or restore the flag in the documentation to match the script's interface.
python environments/state_machine/replay_recording.py /path/to/your/hdf5_data_directory --task <YourTaskName> --enable_camera
tools/env_setup/install_gr00tn1.sh:55
- If the 'base' extra isn't defined in setup.py or pyproject.toml, this install command will fail; please verify that 'base' is a valid extra or revert to 'pip install -e .'.
pip install -e .[base]
mingxin-zheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER
Description