Skip to content

Conversation

@mingxin-zheng
Copy link
Contributor

Fixes #ISSUE_NUMBER

Description

Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the livestream startup failure from a remote Docker container by updating import order directives, expanding Docker configuration for CUDA/conda support, enhancing documentation for raytracing mounts, and adjusting build scripts to skip GPU checks during image construction.

  • Added isort on/off markers around imports in the replay recording script
  • Overhauled the Dockerfile to use a CUDA base image, install required packages, and set up a conda environment with proper entrypoint
  • Expanded the README with raysim mount instructions and detailed run/troubleshooting steps

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/replay_recording.py Added # isort: off/on markers around imports
workflows/robotic_ultrasound/scripts/holoscan_apps/realsense/camera.py Cleaned up extra blank line before main()
workflows/robotic_ultrasound/docker/README.md Added optional raysim mounting and expanded simulation/run guidelines
workflows/robotic_ultrasound/docker/Dockerfile Switched to nvidia/cuda base, installed dependencies, initialized conda
tools/env_setup/bash_utils.sh Updated GPU check to skip when building Docker image
holoscan_i4h/operators/no_op/no_op.py Adjusted spacing in class docstring
Comments suppressed due to low confidence (2)

workflows/robotic_ultrasound/docker/README.md:52

  • [nitpick] Inconsistent raysim mount paths are shown (~/raysim:/root/raysim) versus later (<path-to-raysim>:/workspace/...). Consider unifying these examples to avoid confusion for users.
-    -v ~/raysim:/root/raysim:ro \

workflows/robotic_ultrasound/docker/Dockerfile:32

  • Adding GitHub meta SSH keys to known_hosts is incorrect and may introduce security risks. Use ssh-keyscan github.com or a static known_hosts file instead to capture the host's public key.
curl --silent https://api.github.com/meta | jq --raw-output "'github.com '+.ssh_keys[]'" >> ~/.ssh/known_hosts

mingxin-zheng and others added 17 commits June 17, 2025 08:07
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Contributor Author

/build

1 similar comment
@mingxin-zheng
Copy link
Contributor Author

/build

@mingxin-zheng
Copy link
Contributor Author

/build

1 similar comment
@mingxin-zheng
Copy link
Contributor Author

/build

Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Contributor Author

/build

@mingxin-zheng mingxin-zheng merged commit 3285acc into main Jul 6, 2025
4 checks passed
@mingxin-zheng mingxin-zheng deleted the mz/fix_us_docker branch July 6, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants