-
Notifications
You must be signed in to change notification settings - Fork 5
Fix Failure to Start Simulation LiveStream from Remote Docker Container #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses the livestream startup failure from a remote Docker container by updating import order directives, expanding Docker configuration for CUDA/conda support, enhancing documentation for raytracing mounts, and adjusting build scripts to skip GPU checks during image construction.
- Added isort on/off markers around imports in the replay recording script
- Overhauled the Dockerfile to use a CUDA base image, install required packages, and set up a conda environment with proper entrypoint
- Expanded the README with raysim mount instructions and detailed run/troubleshooting steps
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/replay_recording.py | Added # isort: off/on markers around imports |
| workflows/robotic_ultrasound/scripts/holoscan_apps/realsense/camera.py | Cleaned up extra blank line before main() |
| workflows/robotic_ultrasound/docker/README.md | Added optional raysim mounting and expanded simulation/run guidelines |
| workflows/robotic_ultrasound/docker/Dockerfile | Switched to nvidia/cuda base, installed dependencies, initialized conda |
| tools/env_setup/bash_utils.sh | Updated GPU check to skip when building Docker image |
| holoscan_i4h/operators/no_op/no_op.py | Adjusted spacing in class docstring |
Comments suppressed due to low confidence (2)
workflows/robotic_ultrasound/docker/README.md:52
- [nitpick] Inconsistent raysim mount paths are shown (
~/raysim:/root/raysim) versus later (<path-to-raysim>:/workspace/...). Consider unifying these examples to avoid confusion for users.
- -v ~/raysim:/root/raysim:ro \
workflows/robotic_ultrasound/docker/Dockerfile:32
- Adding GitHub meta SSH keys to known_hosts is incorrect and may introduce security risks. Use
ssh-keyscan github.zerozr99.workers.devor a static known_hosts file instead to capture the host's public key.
curl --silent https://api.github.com/meta | jq --raw-output "'github.com '+.ssh_keys[]'" >> ~/.ssh/known_hosts
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
|
/build |
1 similar comment
|
/build |
|
/build |
1 similar comment
|
/build |
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
|
/build |
Fixes #ISSUE_NUMBER
Description