-
Notifications
You must be signed in to change notification settings - Fork 6
Refactor Holoscan Operators #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d270273 to
af509ba
Compare
|
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors Holoscan operator implementations into a new holohub/ directory and updates the robotic_ultrasound workflow scripts to import and use these external operators. Key changes include:
- Moving
RealsenseOp,ClariusSolumOp,ClariusCastOp, andNoOpintoholohub/operators/*with corresponding CMake build recipes. - Updating workflow application scripts to import operators from
holohub.operatorsinstead of defining them inline. - Adding environment setup scripts (
install_clarius.sh) and modifying the main setup to build and install the new operator libraries.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/.../camera.py | Updated imports to holohub.operators, removed inline operator classes, and adjusted flow wiring. |
| workflows/.../examples/README.md | Removed existing README content (now empty). |
| workflows/.../clarius_solum.py & clarius_cast.py | Switched from inline operator definitions to holohub.operators imports. |
| tools/env_setup/install_clarius.sh & env_setup_robot_us.sh | Added new install script for building holohub operator libraries. |
| holohub/operators/* | Added standalone operator implementations and CMakeLists for building them. |
Comments suppressed due to low confidence (1)
workflows/robotic_ultrasound/scripts/holoscan_apps/examples/README.md:1
- The
examples/README.mdwas cleared out and no longer provides any guidance. Consider restoring or updating this documentation so users know how to run the example apps.
-This folder contains the examples to execute the holoscan sensor apps, and connect with the `policy_runner`.
|
Hi @wendell-hom ,
@jjomier @mingxin-zheng What do you think? Thanks. |
@Nic-Ma yes, I'll look into refactoring the operators in telesurgery after getting some feedback on this one |
jjomier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the tests passing?
Yes, tests are passing. There is one visualization test, that is outdated and needs Yun to look into. I'll start a thread on that in i4h channel |
|
/build |
|
/build |
workflows/robotic_ultrasound/scripts/holoscan_apps/clarius_cast/clarius_cast.py
Show resolved
Hide resolved
mingxin-zheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wendell-hom for the well-structured refactoring that centralizes operator implementations from scattered workflow locations into a single directory. I only had two minor comments above and please feel free to address them (or not)
be0d3cd to
705b02a
Compare
|
/build |
@Nic-Ma, I don't think putting holoscan_i4h under If we don't care so much about having a source folder, then we could do something like the following where holoscan_i4h and simulation can have their own build and install folder and keep them independent. A possible advantage to this might be that it'll be easier to trigger the builds for holoscan side vs simulation side separately. |
|
Hi @wendell-hom , OK, let's merge without Thanks. |
Description
Factor out holoscan operators from robotic_ultrasound workflow.
Operators are under
holohub/directory for the time being -- folder name is subject to change.When tools/env_setup_robot_surgery.sh is run, it will run
env_setup/install_clarius_.shwhich will trigger the cmake build for holoscan operators and will result in aholohub/build/andholohub/install/directory.To-do: