Skip to content

Conversation

@yiheng-wang-nv
Copy link
Contributor

Fixes #151

Description

Signed-off-by: Yiheng Wang <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MIRA tutorial to align with the new assets and key mapping configurations. Key changes include reordering and updating imports and configurations, replacing hardcoded asset paths with values from the new configuration module, and adjusting the keyboard event handling logic to use the updated key maps.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tutorials/assets/bring_your_own_robot/Virtual_Incision_MIRA/teleoperate_virtual_incision_mira.py Updated asset management, key mapping integration, and joint update logic to match new configurations.
tutorials/assets/bring_your_own_robot/Virtual_Incision_MIRA/mira_configs.py Added new configuration module for asset paths and key mappings.
Comments suppressed due to low confidence (1)

tutorials/assets/bring_your_own_robot/Virtual_Incision_MIRA/teleoperate_virtual_incision_mira.py:82

  • [nitpick] The transition from uppercase constants (SWITCH_KEY) to lowercase (switch_key) in the updated code is acceptable given the new configurations, but ensure consistency across the code base and documentation.
if key == switch_key:

Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv yiheng-wang-nv requested a review from Copilot May 30, 2025 05:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Virtual Incision MIRA tutorial to work with the new asset layout by externalizing asset paths and input mappings into a dedicated config module, and refactoring the main teleoperation script.

  • Extracted USD paths, joint/camera mappings, and keys into mira_configs.py.
  • Refactored teleoperate_virtual_incision_mira.py to import from the new config, reorganize the Assets class, and streamline initialization.
  • Adjusted keyboard handling to support rotation and grasp inputs and updated import ordering.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tutorials/assets/bring_your_own_robot/Virtual_Incision_MIRA/teleoperate_virtual_incision_mira.py Refactored to use mira_configs, reorganized imports and asset initialization, and updated joint/camera update logic.
tutorials/assets/bring_your_own_robot/Virtual_Incision_MIRA/mira_configs.py New configuration module defining asset paths, key maps, and related constants.
Comments suppressed due to low confidence (1)

tutorials/assets/bring_your_own_robot/Virtual_Incision_MIRA/teleoperate_virtual_incision_mira.py:130

  • Since this loop only handles a single index, consider operating directly on camera_prims[0] instead of iterating over a single-element list to simplify the code.
for i in [0]:

@mingxin-zheng
Copy link
Contributor

Hi @yiheng-wang-nv , if the new assets are working fine, can you update the hash in the i4h-asset-catalog repo? Thanks!

@yiheng-wang-nv
Copy link
Contributor Author

Hi @yiheng-wang-nv , if the new assets are working fine, can you update the hash in the i4h-asset-catalog repo? Thanks!

Hi @mingxin-zheng , thanks, I tested and submitted a PR: isaac-for-healthcare/i4h-asset-catalog#24

@mingxin-zheng mingxin-zheng merged commit 54c9538 into main Jun 3, 2025
3 checks passed
@mingxin-zheng mingxin-zheng deleted the update-mira-tutorial branch June 3, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance MIRA tutorial

4 participants