Add support for NV Video Codec #153
Conversation
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
|
|
||
| # capture room camera stream (optional) | ||
| NDDS_DISCOVERY_PEERS=${PATIENT_IP} python surgeon/camera.py --name room --width 1280 --height 720 | ||
| NDDS_DISCOVERY_PEERS=${PATIENT_IP} python surgeon/camera.py --name room --width 1280 --height 720 [--decoder nvc] |
There was a problem hiding this comment.
r we going it by default.. because for igx we still have not solved the problem...? if so, then just provide an option to use --decoder nvjpeg | nvc..
There was a problem hiding this comment.
No. That's why I put them in square brackets as "optional" parameter.
| copy_to_host=False, | ||
| width=self.width, | ||
| height=self.height, | ||
| codec="H264", |
There was a problem hiding this comment.
you can take from encode_params (which is a json.. can be sent via args)
bitrate, frame_rate etc.. you can simple change to frame_rate=self.encoder_params("framerate", 60) and so on
There was a problem hiding this comment.
Thanks! I've updated it in 5884924.
The change includes a sample JSON file and an updated README with usage examples and options for each parameter.
| height=self.height, | ||
| codec="H264", | ||
| preset="P3", | ||
| bitrate=10000000, |
There was a problem hiding this comment.
same as encode_params
There was a problem hiding this comment.
Thanks! I've updated it in 5884924.
The change includes a sample JSON file and an updated README with usage examples and options for each parameter.
|
Otherwise LGTM... |
SachidanandAlle
left a comment
SachidanandAlle
left a comment
There was a problem hiding this comment.
Looks good to me
Signed-off-by: Victor Chang <[email protected]>
Add a new encoder/decoder option:
nvcusing NVIDIA Video Codec.The encoder and decoder operators are in C++ with Python wrappers.
Known Issue
The simulated surgeon app prints the following error when attempting to access the Tensor in the
CameraStreamStatsoperators: