-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor lerobot format conversion and upgrade Isaaclab to v2.1.0 #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the LeRobot format conversion tests, upgrades Isaaclab to v2.1.0 (with accompanying patch application for random texture generation and semantic tags), and adds segmentation support in multiple modules.
- Updated test imports and parameters (fps and image dimensions) for dataset creation.
- Removed the legacy convert_hdf5_to_lerobot.py script and updated references in training and testing.
- Enhanced simulation and data collection logic by including semantic segmentation and additional camera metadata.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/robotic_ultrasound/tests/test_training/test_training.py | Updated test cases to pass a feature builder and modified dataset parameters. |
| workflows/robotic_ultrasound/scripts/training/pi_zero/convert_hdf5_to_lerobot.py | Entire file removed to phase out legacy conversion code. |
| workflows/robotic_ultrasound/scripts/training/gr00t_n1/train.py | Updated training pipeline for GR00T-N1 model, including torchrun support for multi-GPU training. |
| workflows/robotic_ultrasound/scripts/simulation/* | Modified calls to capture_camera_images to handle segmentation output and added new camera metadata collection. |
| tools/env_setup/install_isaac.sh | Upgraded Isaaclab clone version and added patch application steps for random texture and semantic tags. |
| workflows/robotic_ultrasound/scripts/policy_runner/gr00tn1/utils.py | Adjusted normalization settings for state and action transforms. |
Comments suppressed due to low confidence (1)
workflows/robotic_ultrasound/scripts/policy_runner/gr00tn1/utils.py:101
- The normalization mode for 'state.panda_hand' has been changed from 'min_max' to 'mean_std'. Please ensure this change is consistent with the overall data normalization pipeline and documented accordingly.
"state.panda_hand": "mean_std",
Signed-off-by: YunLiu <[email protected]>
workflows/robotic_ultrasound/tests/test_training/test_training.py
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/training/pi_zero/README.md
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/training/gr00t_n1/README.md
Outdated
Show resolved
Hide resolved
...exts/robotic_us_ext/robotic_us_ext/tasks/ultrasound/approach/config/teleop/ik_rel_env_cfg.py
Show resolved
Hide resolved
...c_us_ext/robotic_us_ext/tasks/ultrasound/approach/config/franka/franka_manager_rl_env_cfg.py
Show resolved
Hide resolved
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
|
test log: |
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
...exts/robotic_us_ext/robotic_us_ext/tasks/ultrasound/approach/config/teleop/ik_rel_env_cfg.py
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/training/convert_hdf5_to_lerobot.py
Show resolved
Hide resolved
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
|
/build |
Signed-off-by: YunLiu <[email protected]>
|
/build |
Signed-off-by: YunLiu <[email protected]>
|
/build |
1 similar comment
|
/build |
Part of #127
Description
BaseFeatureDictto refactor the convert_hdf5_to_lerobot.py support both Pi0 and GR00T data format