-
Notifications
You must be signed in to change notification settings - Fork 5
allow choice of ultrasound probes matching raysim #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5ee4114
allow choice of ultrasound probes matching raysim
maximilianofir 8565953
Update workflows/robotic_ultrasound/scripts/simulation/examples/ultra…
maximilianofir a61e115
resolve MR comments
maximilianofir df4025a
Merge branch 'maxo/fix_ultrasound_probes' of https://github.com/isaac…
maximilianofir 6068366
Merge commit 'c3f6498ad31f743cc49ac032c61d2f796ea5b90b' into maxo/fix…
maximilianofir 795ea2f
linter
maximilianofir 2729862
resolved comments, removed linear probe
maximilianofir 97c3a18
sector_angle fix
maximilianofir fb034d6
Merge branch 'main' into maxo/fix_ultrasound_probes
mingxin-zheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -242,13 +242,17 @@ Optionally, the simulator supports customization through JSON configuration file | |
|
|
||
| ```json | ||
| { | ||
| "probe_type": "curvilinear", // or "linear" | ||
| "probe_params": { | ||
| "num_elements": 4096, | ||
| "num_elements": 256, | ||
| "opening_angle": 73.0, | ||
mingxin-zheng marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "radius": 45.0, | ||
| "frequency": 2.5, | ||
| "elevational_height": 7.0, | ||
| "num_el_samples": 10 | ||
| "num_el_samples": 1, | ||
| "f_num": 1.0, | ||
| "speed_of_sound": 1.54, | ||
| "pulse_duration": 2.0 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. May I know where you get these numbers? Thanks.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are the defaults from raysim. |
||
| }, | ||
| "sim_params": { | ||
| "conv_psf": true, | ||
|
|
@@ -262,12 +266,15 @@ Optionally, the simulator supports customization through JSON configuration file | |
|
|
||
| | Parameter | Description | Default Value | | ||
| |-----------|-------------|---------------| | ||
| | num_elements | Number of elements in the ultrasound probe | 4096 | | ||
| | opening_angle | Beam opening angle in degrees | 73.0 | | ||
| | radius | Radius of the ultrasound probe in mm | 45.0 | | ||
| | num_elements | Number of elements in the ultrasound probe | 256 | | ||
| | opening_angle | Beam opening angle in degrees | 73.0 (curvilinear) / 0.0 (linear) | | ||
mingxin-zheng marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| | radius | Radius of the ultrasound probe in mm | 45.0 (curvilinear) / 0.0 (linear) | | ||
| | frequency | Ultrasound frequency in MHz | 2.5 | | ||
| | elevational_height | Height of the elevation plane in mm | 7.0 | | ||
| | num_el_samples | Number of samples in the elevation direction | 10 | | ||
| | num_el_samples | Number of samples in the elevation direction | 1 | | ||
| | f_num | F-number (unitless) | 1.0 | | ||
| | speed_of_sound | Speed of sound in mm/us | 1.54 | | ||
| | pulse_duration | Pulse duration in cycles | 2.0 | | ||
|
|
||
| ##### Simulation Parameters | ||
|
|
||
|
|
@@ -283,6 +290,7 @@ You only need to specify the parameters you want to change - any omitted paramet | |
|
|
||
| ```json | ||
| { | ||
| "probe_type": "linear", | ||
mingxin-zheng marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "probe_params": { | ||
| "frequency": 3.5, | ||
| "radius": 55.0 | ||
|
|
@@ -324,3 +332,4 @@ To see the ultrasound probe moving, please ensure the `topic_ultrasound_info` is | |
| | --topic_out | Topic name to publish generated ultrasound data | topic_ultrasound_data | | ||
| | --config | Path to custom JSON configuration file with probe parameters and simulation parameters | None | | ||
| | --period | Period of the simulation (in seconds) | 1/30.0 (30 Hz) | | ||
| | --probe_type | Type of ultrasound probe to use ("curvilinear" or "linear") | "curvilinear" | | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
// or "linear"is allowed format in JSON.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the comment