Skip to content

Conversation

@mingxin-zheng
Copy link
Contributor

@mingxin-zheng mingxin-zheng commented May 10, 2025

This PR adds Docker support for the robotic ultrasound simulation, cleans up an unused ONNX utility, and refactors environment setup scripts for consistency in conda and docker env.

@mingxin-zheng
Copy link
Contributor Author

/build

Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Contributor Author

/build

@mingxin-zheng
Copy link
Contributor Author

/build

@mingxin-zheng mingxin-zheng requested a review from KumoLiu May 23, 2025 12:03
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Contributor Author

/build

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the built docker image to run CI in blossom? In that case, we can automatically test this Dockerfile.

Thanks.

Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Contributor Author

Hi @Nic-Ma , we will first need help from @wendell-hom to set up the docker build pipeline in nightly. Then we can discuss if we can move some tests using this docker build. Thanks!

@mingxin-zheng
Copy link
Contributor Author

/build

@mingxin-zheng mingxin-zheng requested a review from Copilot May 24, 2025 02:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Docker support for the robotic ultrasound simulation, cleans up an unused ONNX utility, and refactors environment setup scripts for consistency.

  • Remove unused ONNX import and loader function from state machine utilities
  • Introduce Dockerfile and README for building/running the ultrasound simulation container
  • Refactor and centralize dependency installation scripts under tools/env_setup

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/utils.py Removed onnxruntime import and load_onnx_model function to clean up unused code
workflows/robotic_ultrasound/docker/README.md Added step-by-step guide for building the Docker image and streaming simulation output
workflows/robotic_ultrasound/docker/Dockerfile New Dockerfile defining the runtime environment and dependencies for ultrasound simulation
workflows/robotic_surgery/docker/README.md Cleaned up legacy asset-prep section and updated simulation run example
workflows/robotic_surgery/docker/Dockerfile Updated asset-catalog pip target to use @main branch
tools/env_setup_robot_us.sh Replaced inline lerobot install with call to new install_lerobot.sh
tools/env_setup/install_robotic_us_ext.sh Added PYTHON_EXECUTABLE override and tightened pip flags for extension install
tools/env_setup/install_pi0.sh Switched OpenPI clone to HTTPS and unified pip install with PYTHON_EXECUTABLE
tools/env_setup/install_lerobot.sh New standalone script for cloning and installing lerobot
tools/env_setup/install_cosmos_transfer1.sh Moved cuDNN install out and added --no-build-isolation to transformer-engine install
Comments suppressed due to low confidence (3)

workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/utils.py:274

  • The load_onnx_model function and its ONNX Runtime import were removed, but any existing calls to this loader will now break; ensure all references are updated or removed.
def load_onnx_model(model_path):

tools/env_setup/install_cosmos_transfer1.sh:27

  • The default COSMOS_TRANSFER_DIR uses $$PROJECT_ROOT, which expands incorrectly to the PID; it should be ${1:-$PROJECT_ROOT/third_party/cosmos-transfer1}.
COSMOS_TRANSFER_DIR=${1:-$$PROJECT_ROOT/third_party/cosmos-transfer1}

tools/env_setup/install_pi0.sh:31

  • [nitpick] Exiting with status 1 when the OpenPI directory already exists flags an error; to make the setup idempotent, consider using exit 0 or simply skipping the clone step.
exit 1

Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Contributor Author

/build

@mingxin-zheng mingxin-zheng merged commit 4c94f61 into main May 24, 2025
4 checks passed
@mingxin-zheng mingxin-zheng deleted the mz/docker_robotus branch May 24, 2025 17:03
mingxin-zheng referenced this pull request May 28, 2025
### Description
Integrate[
cosmos-transfer1](https://github.com/nvidia-cosmos/cosmos-transfer1/blob/861254a98a01d4e23f3e41d8a213d002a737e1d3/examples/inference_cosmos_transfer1_7b.md)
with our proposed guided generation pipeline to the I4H workflow.

---------

Signed-off-by: Pengfei Guo <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Co-authored-by: YunLiu <[email protected]>
Co-authored-by: Mingxin Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants