-
Notifications
You must be signed in to change notification settings - Fork 5
Add Playback Recording Feature #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds the Playback Recording Feature by introducing a new file that implements playback of recorded simulation actions using HDF5 files, and resetting the simulation environment accordingly. Key changes include:
- Adding a new script (playback_recorded.py) to handle playback of recorded episodes.
- Integrating argument parsing and configuration loading for simulation tasks.
- Implementing functions to retrieve episode data and reset both the robot and target state in the simulation.
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Outdated
Show resolved
Hide resolved
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please help change the hardcode "cuda:0" to be a device parameter?
Others look good to me.
Thanks.
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Outdated
Show resolved
Hide resolved
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/playback_recorded.py
Show resolved
Hide resolved
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
workflows/robotic_ultrasound/scripts/simulation/environments/state_machine/replay_recording.py
Show resolved
Hide resolved
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
|
/build |
|
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the features and tests.
Will merge this once we settle down if 0.1.1 tagging is needed.
part of #127
Add Playback Recording Feature