Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI bug in the Descriptions control where the colon separator was always visible in Plain mode, even when no label was present. The fix adds a style rule that conditionally shows the colon only when the Label property is not null or empty.
Changes:
- Added conditional visibility logic for the colon in ItemAlignment=Plain mode using StringConverters.IsNotNullOrEmpty
Collaborator
Author
|
@copilot add HeadlessTest for this PR. |
Contributor
… mode (#885) * Initial plan * test: add HeadlessTest for colon visibility in Plain mode Co-authored-by: zdpcdt <54255897+zdpcdt@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: zdpcdt <54255897+zdpcdt@users.noreply.github.com>
|
rabbitism
approved these changes
Feb 10, 2026
zdpcdt
added a commit
that referenced
this pull request
Feb 12, 2026
* fix: the colon should invisible when ItemsAlignmen=Plain. * test: add HeadlessTest for colon visibility in DescriptionsItem Plain mode (#885) * Initial plan * test: add HeadlessTest for colon visibility in Plain mode Co-authored-by: zdpcdt <54255897+zdpcdt@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: zdpcdt <54255897+zdpcdt@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> (cherry picked from commit 0ad5d3a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.