[Codegen] Fix ArgCompare vectorization#23775
Open
bangtianliu wants to merge 1 commit intoiree-org:mainfrom
Open
[Codegen] Fix ArgCompare vectorization#23775bangtianliu wants to merge 1 commit intoiree-org:mainfrom
bangtianliu wants to merge 1 commit intoiree-org:mainfrom
Conversation
c7d3608 to
c36f9af
Compare
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
c36f9af to
04423dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes ArgCompare vectorization to use input shape instead of the output shape for inferring vector sizes.
The existing implementation uses
inferSizesFromIR(argCompareOp.getDpsInits()[0]), which fails for rank-reducing operations. Inferring from the output returns incorrect sizes, especially when outputs come from rank-reducingtensor.extract_sliceoperations.Example failure case:
For reduction ops,
inferSizesFromIR(linalgOp, ...)useslinalgOp.getNumLoops()to map ALL loop dimensions (parallel + reduction) to operands.Assisted-by: Claude Code