Skip to content

[Codegen][nfc] Drop redundant public from struct inheritance. 3/5 #23771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanhanW merged 2 commits into from
Mar 13, 2026
Merged

[Codegen][nfc] Drop redundant public from struct inheritance. 3/5 #23771

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
518b724
[Codegen] Drop redundant `public` from struct inheritance. 3/5
hanhanW Mar 12, 2026
16572dc
fix lint issue manually
hanhanW Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/BubbleUpOrdinalOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace {
/// `iree_tensor_ext.dispatch.workload.ordinal` ops.
template <typename CastOpTy>
struct BubbleUpAcrossCastOp
: public OpRewritePattern<IREE::TensorExt::DispatchWorkloadOrdinalOp> {
: OpRewritePattern<IREE::TensorExt::DispatchWorkloadOrdinalOp> {
using Base::Base;
LogicalResult
matchAndRewrite(IREE::TensorExt::DispatchWorkloadOrdinalOp ordinalOp,
Expand Down
9 changes: 4 additions & 5 deletions compiler/src/iree/compiler/Codegen/Common/CPU/CPUPrepareUkernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ dropBatchTileSize(IREE::CPU::LoweringConfigAttr config) {

/// Pattern to convert linalg.batch_mmt4d with batch dim = 1 into mmt4d.
struct ConvertBatchMmt4DtoMmt4DPattern
: public OpRewritePattern<linalg::BatchMmt4DOp> {
: OpRewritePattern<linalg::BatchMmt4DOp> {
using Base::Base;

LogicalResult matchAndRewrite(linalg::BatchMmt4DOp op,
Expand Down Expand Up @@ -252,7 +252,7 @@ struct ConvertBatchMmt4DtoMmt4DPattern
}
};

struct Convert3DPackto2DPackPattern : public OpRewritePattern<linalg::PackOp> {
struct Convert3DPackto2DPackPattern : OpRewritePattern<linalg::PackOp> {
using Base::Base;

LogicalResult matchAndRewrite(linalg::PackOp packOp,
Expand Down Expand Up @@ -326,8 +326,7 @@ struct Convert3DPackto2DPackPattern : public OpRewritePattern<linalg::PackOp> {
}
};

struct Convert5DUnPackto4DUnPackPattern
: public OpRewritePattern<linalg::UnPackOp> {
struct Convert5DUnPackto4DUnPackPattern : OpRewritePattern<linalg::UnPackOp> {
using Base::Base;

LogicalResult matchAndRewrite(linalg::UnPackOp unpackOp,
Expand Down Expand Up @@ -409,7 +408,7 @@ struct Convert5DUnPackto4DUnPackPattern
};

struct CPUPrepareUkernelsPass
: public impl::CPUPrepareUkernelsPassBase<CPUPrepareUkernelsPass> {
: impl::CPUPrepareUkernelsPassBase<CPUPrepareUkernelsPass> {
void getDependentDialects(DialectRegistry &registry) const override {
registry.insert<linalg::LinalgDialect, arith::ArithDialect,
tensor::TensorDialect, scf::SCFDialect>();
Expand Down
4 changes: 2 additions & 2 deletions compiler/src/iree/compiler/Codegen/Common/CPU/CPUPropagateDataLayout.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace {
/// introducing tensor.expand_shape op on the destination tensor. However, it is
/// not common in practice, so it is not supported now.
struct SinkDownCollapsingUnitDimsAcrossUnpack final
: public OpRewritePattern<linalg::UnPackOp> {
: OpRewritePattern<linalg::UnPackOp> {
using Base::Base;
LogicalResult matchAndRewrite(linalg::UnPackOp op,
PatternRewriter &rewriter) const override {
Expand Down Expand Up @@ -147,7 +147,7 @@ struct SinkDownCollapsingUnitDimsAcrossUnpack final
};

struct CPUPropagateDataLayoutPass final
: public impl::CPUPropagateDataLayoutPassBase<CPUPropagateDataLayoutPass> {
: impl::CPUPropagateDataLayoutPassBase<CPUPropagateDataLayoutPass> {
void getDependentDialects(DialectRegistry &registry) const override {
registry.insert<linalg::LinalgDialect, tensor::TensorDialect>();
}
Expand Down
6 changes: 3 additions & 3 deletions compiler/src/iree/compiler/Codegen/Common/CombineLayoutTransformation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ shouldDoReshapesByExpansion(IREE::Codegen::RelayoutCombinationScope scope) {
/// the leaves of the chain. The leaves are simply relayout ops that have non
/// relayout op users. The `controlFn` is a callback on the leaf OpResult that
/// provides control over whether or not to insert a map_store op.
struct InsertMapStoreOpPattern : public RewritePattern {
struct InsertMapStoreOpPattern : RewritePattern {
InsertMapStoreOpPattern(MLIRContext *context,
CombineRelayoutOpsControlFnRef controlFn = nullptr,
PatternBenefit benefit = 1)
Expand Down Expand Up @@ -1193,7 +1193,7 @@ FailureOr<MapLoadOp> foldIntoMapLoad(RewriterBase &rewriter, Operation *op,

/// Pattern to fold consumer relayout ops into a producer map_load.
struct FoldConsumerRelayoutIntoMapLoadPattern
: public OpRewritePattern<IREE::LinalgExt::MapLoadOp> {
: OpRewritePattern<IREE::LinalgExt::MapLoadOp> {
using OpRewritePattern::OpRewritePattern;

LogicalResult matchAndRewrite(IREE::LinalgExt::MapLoadOp mapLoadOp,
Expand Down Expand Up @@ -1249,7 +1249,7 @@ insertIdentityMapLoad(RewriterBase &rewriter, OpResult root,
/// op consumers. The identity map_load can then be used to fold consumer
/// relayout ops into it iteratively.
struct InsertMapLoadOpPattern
: public OpRewritePattern<IREE::Codegen::LoadFromBufferOp> {
: OpRewritePattern<IREE::Codegen::LoadFromBufferOp> {
InsertMapLoadOpPattern(MLIRContext *context, bool combineNonComplexChains)
: OpRewritePattern(context),
combineNonComplexChains(combineNonComplexChains) {}
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/ConcretizePadResultShape.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ namespace {

/// Concretizes tensor.pad op's result shape if its source op implements
/// OffsetSizeAndStrideOpInterface. For example, pad(extract_slice).
struct ConcretizePadResultShape final : public OpRewritePattern<tensor::PadOp> {
struct ConcretizePadResultShape final : OpRewritePattern<tensor::PadOp> {
using Base::Base;

LogicalResult matchAndRewrite(tensor::PadOp padOp,
Expand Down
11 changes: 5 additions & 6 deletions compiler/src/iree/compiler/Codegen/Common/ConvertBf16ArithToF32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Value convertRankedFloat(OpBuilder &builder, Type type, ValueRange inputs,

// Converts from |SourceType| to |TargetType|.
template <typename SourceType, typename TargetType>
struct PrimitiveTypeConverter : public TypeConverter {
struct PrimitiveTypeConverter : TypeConverter {
explicit PrimitiveTypeConverter() {
addConversion([](Type type) { return type; });
addConversion([&](SourceType type) -> Type {
Expand Down Expand Up @@ -102,8 +102,7 @@ struct PrimitiveTypeConverter : public TypeConverter {
};

template <typename SourceType, typename TargetType>
struct FloatTypeConverter
: public PrimitiveTypeConverter<SourceType, TargetType> {
struct FloatTypeConverter : PrimitiveTypeConverter<SourceType, TargetType> {
explicit FloatTypeConverter() {
this->addSourceMaterialization(convertRankedFloat);
this->addTargetMaterialization(convertRankedFloat);
Expand All @@ -112,7 +111,7 @@ struct FloatTypeConverter

// Tries to completely convert a generic Operation.
// This will process attributes, result types, and nested regions.
struct GenericTypeConversionPattern : public ConversionPattern {
struct GenericTypeConversionPattern : ConversionPattern {
GenericTypeConversionPattern(MLIRContext *context,
TypeConverter &typeConverter)
: ConversionPattern(typeConverter, MatchAnyOpTypeTag(), 0, context) {}
Expand Down Expand Up @@ -163,7 +162,7 @@ struct GenericTypeConversionPattern : public ConversionPattern {
// unsigned integer values.
template <typename OpTy, typename TypeTy,
typename OperandToResultWidthLegalityRelation>
struct ConvertTypeSensitiveArithCastOp : public OpConversionPattern<OpTy> {
struct ConvertTypeSensitiveArithCastOp : OpConversionPattern<OpTy> {
using OpConversionPattern<OpTy>::OpConversionPattern;
LogicalResult
matchAndRewrite(OpTy op, typename OpTy::Adaptor adaptor,
Expand Down Expand Up @@ -231,7 +230,7 @@ class PropagateCastF : public OpRewritePattern<SrcOp> {

// Converts BF16s to F32s.
struct PromoteBF16ToF32Converter
: public FloatTypeConverter<BFloat16Type, Float32Type> {
: FloatTypeConverter<BFloat16Type, Float32Type> {
Type getTargetType(BFloat16Type type) override {
return Float32Type::get(type.getContext());
}
Expand Down
5 changes: 2 additions & 3 deletions compiler/src/iree/compiler/Codegen/Common/ConvertToDestinationPassingStylePass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,7 @@ replaceUnpackEmptyWithAllocTensor(OpBuilder &b,
}

namespace {
struct RemoveCstOutsDependency
: public OpInterfaceRewritePattern<linalg::LinalgOp> {
struct RemoveCstOutsDependency : OpInterfaceRewritePattern<linalg::LinalgOp> {
using OpInterfaceRewritePattern<linalg::LinalgOp>::OpInterfaceRewritePattern;

LogicalResult matchAndRewrite(linalg::LinalgOp op,
Expand Down Expand Up @@ -577,7 +576,7 @@ struct RemoveCstOutsDependency
/// ```
/// This is a workaround for #11273 while a proper fix lands.
struct SwitchStoreOfIfResultValue
: public OpRewritePattern<IREE::TensorExt::DispatchTensorStoreOp> {
: OpRewritePattern<IREE::TensorExt::DispatchTensorStoreOp> {
using Base::Base;

LogicalResult matchAndRewrite(IREE::TensorExt::DispatchTensorStoreOp storeOp,
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/ConvertUnsupportedFloatArithPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ struct ExtFFromSmallFloat final : OpRewritePattern<arith::ExtFOp> {
};

struct ConvertUnsupportedFloatArithPass final
: public impl::ConvertUnsupportedFloatArithPassBase<
: impl::ConvertUnsupportedFloatArithPassBase<
ConvertUnsupportedFloatArithPass> {
void runOnOperation() override;
using Base::Base;
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/ConvertUnsupportedFloatToIntBuffers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ struct ConvertMemRefAlloc final : OpConversionPattern<memref::AllocOp> {

// Tries to completely convert a generic Operation.
// This will process attributes, result types, and nested regions.
struct GenericTypeConversionPattern : public ConversionPattern {
struct GenericTypeConversionPattern : ConversionPattern {
GenericTypeConversionPattern(TypeConverter &typeConverter,
MLIRContext *context)
: ConversionPattern(typeConverter, MatchAnyOpTypeTag(), 0, context) {}
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/ConvertWorkgroupForallToPCF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ struct ConvertWorkgroupForall : OpRewritePattern<scf::ForallOp> {
};

struct ConvertWorkgroupForallToPCFPass final
: public impl::ConvertWorkgroupForallToPCFPassBase<
: impl::ConvertWorkgroupForallToPCFPassBase<
ConvertWorkgroupForallToPCFPass> {
void runOnOperation() override;
using Base::Base;
Expand Down
4 changes: 2 additions & 2 deletions compiler/src/iree/compiler/Codegen/Common/DecomposePackUnPackOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace {

/// A wrapper pattern that calls linalg::lowerPack on linalg::PackOp. It lowers
/// a linalg.pack op to tensor.pad + tensor.expand_shape + linalg.transpose ops.
struct LowerPackPattern : public OpRewritePattern<linalg::PackOp> {
struct LowerPackPattern : OpRewritePattern<linalg::PackOp> {
using Base::Base;

explicit LowerPackPattern(MLIRContext *context,
Expand Down Expand Up @@ -78,7 +78,7 @@ struct LowerPackPattern : public OpRewritePattern<linalg::PackOp> {
/// A wrapper pattern that calls linalg::lowerUnPack on linalg::UnPackOp. It
/// lowers a linalg.unpack op to tensor.empty + linalg.transpose +
/// tensor.collapse_shape + tensor.extract_slice ops.
struct LowerUnPackPattern : public OpRewritePattern<linalg::UnPackOp> {
struct LowerUnPackPattern : OpRewritePattern<linalg::UnPackOp> {
using Base::Base;

explicit LowerUnPackPattern(MLIRContext *context,
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/DecomposeSoftmax.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ static bool isScalarOrTensorOfSizeOne(Type t) {
return t.isIntOrIndexOrFloat();
}

struct FuseElementWiseGenericOps : public OpRewritePattern<linalg::GenericOp> {
struct FuseElementWiseGenericOps : OpRewritePattern<linalg::GenericOp> {
using Base::Base;

LogicalResult matchAndRewrite(linalg::GenericOp genericOp,
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/EncodingUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class MaterializeEncodingTypeConverter : public TypeConverter {
};

/// Conversion target to use for for materializing the encoding.
struct MaterializeEncodingConversionTarget : public ConversionTarget {
struct MaterializeEncodingConversionTarget : ConversionTarget {
MaterializeEncodingConversionTarget(MLIRContext &context);
};

Expand Down
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/ExtractAddressComputation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ template <typename StoreLoadLikeOp, Value (*getSrcMemRef)(StoreLoadLikeOp),
Value /*srcMemRef*/, ArrayRef<Value> /*indices*/),
SmallVector<OpFoldResult> (*getViewSizeForEachDim)(
RewriterBase & /*rewriter*/, StoreLoadLikeOp /*storeLoadOp*/)>
struct StoreLoadLikeOpRewriter : public OpRewritePattern<StoreLoadLikeOp> {
struct StoreLoadLikeOpRewriter : OpRewritePattern<StoreLoadLikeOp> {
using OpRewritePattern<StoreLoadLikeOp>::OpRewritePattern;

LogicalResult matchAndRewrite(StoreLoadLikeOp storeLoadLikeOp,
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/iree/compiler/Codegen/Common/FastMathPatterns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ static Value evalErfPolynomial(Value x, Value t, ArrayRef<Value> coeffs,
// Pattern to lower math.erf to its device lib implementation
// (from
// https://github.com/ROCm/llvm-project/blob/amd-staging/amd/device-libs/ocml/src/erfF.cl#L11)
struct FastErfPattern : public OpRewritePattern<math::ErfOp> {
struct FastErfPattern : OpRewritePattern<math::ErfOp> {
using Base::Base;

LogicalResult matchAndRewrite(math::ErfOp op,
Expand Down
Loading
Loading