[plugins][nfc] Drop redundant public from struct inheritance. 1/5#23769
Merged
[plugins][nfc] Drop redundant public from struct inheritance. 1/5#23769
public from struct inheritance. 1/5#23769Conversation
`public` is the default access specifier for struct inheritance in C++, so `struct Foo : public Bar` is equivalent to `struct Foo : Bar`. Signed-off-by: hanhanW <[email protected]>
kuhar
approved these changes
Mar 12, 2026
Member
kuhar
left a comment
kuhar
left a comment
There was a problem hiding this comment.
Most of these, if not all, can be made final. I wish we had a clang-tidy check for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publicis the default access specifier for struct inheritance in C++, sostruct Foo : public Baris equivalent tostruct Foo : Bar.