This repository was archived by the owner on Aug 21, 2024. It is now read-only.
migrate states to new code standard #9088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 90f8ce8
This pull request refactors several files in the
client-coreandeditorpackages to use theEngineinstance for accessing the backend services, instead of the deprecatedAPIclass. This improves the code quality, consistency, and performance of the client and the editor. It also deletes an unused fileInviteTypeService.ts.References
closes #insert number here
Explanation
🤖 Generated by Copilot at 90f8ce8
Engineinstance instead of theAPIclass that was deprecated (link, link, link, link, link, link, link, link, link, link, link)matchesandAPIfromLocationInstanceConnectionService.ts,OEmbedService.ts, andEditorActiveInstanceService.ts(link, link, link)Enginefrom@etherealengine/engine/src/ecs/classes/Engineto access theapiproperty for interacting with the backend services (link, link)API.instance.client.servicewithEngine.instance.api.servicein theLocationInstanceConnectionServiceclass (link)fetchDataandprovisionServermethods from theOEmbedServiceandEditorActiveInstanceServiceclasses to theOEmbedStateandEditorActiveInstanceStatestate definitions respectively, to simplify the classes and make the methods more accessible as properties of the states (link, link)OEmbedActionsandEditorActiveInstanceActionclasses and theOEmbedServiceReceptorandEditorActiveInstanceServiceReceptorfunctions from theOEmbedServiceandEditorActiveInstanceServicefiles, to eliminate the unnecessary use of actions and receptors for the services, since the state can be updated directly by thefetchDataandprovisionServermethods (link, link)EditorActiveInstanceStatestate definition (link)EditorActiveInstanceServicewithEditorActiveInstanceStatein theEditorInstanceNetworkingSystemandWorldInstanceConnectionfiles, to use the updated state definition that contains thegetActiveInstancesandprovisionServermethods (link, link, link, link)EditorActiveInstanceServicefile from thepackages/editor/src/components/realtimefolder to thepackages/client-core/src/common/servicesfolder, to reorganize the code structure and improve the modularity and reusability of the service (link)InviteTypeServicefile from thepackages/client-core/src/social/servicesfolder, as it was no longer needed (link)🤖 Generated by Copilot at 90f8ce8
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist