Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

@MoizAdnan
Copy link
Contributor

@MoizAdnan MoizAdnan commented Oct 11, 2023

Summary

🤖 Generated by Copilot at 75de7fc

This pull request refactors the usage of the app.service(instancePath) service in various modules and test cases. It replaces the internal methods with the public ones, and removes some unnecessary or redundant code. The goal is to improve the consistency, readability, and compatibility of the code with the FeathersJS framework.

References

#8871

Explanation

🤖 Generated by Copilot at 75de7fc

  • Replace internal methods with public methods for app.service(instancePath) service to avoid using undocumented and unsupported FeathersJS methods (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Simplify and improve the hooks for the instance service by using imported types and classes, and avoiding internal methods (link, link)
  • Use KnexService class as the base class for the InstanceService class, and remove unnecessary constructor and methods (link, link, link)
  • Remove app parameter from the constructor of the InstanceService class, since it is not needed anymore (link)
  • Remove unused imports from the instance.class.ts file (link)

🤖 Generated by Copilot at 75de7fc

We're breaking free from the internal chains
We're using public methods to unleash our power
We're refactoring the code to make it shine
We're the masters of the instance service

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@MoizAdnan MoizAdnan marked this pull request as ready for review October 12, 2023 07:03
@hanzlamateen hanzlamateen merged commit 49bffcf into dev Oct 15, 2023
@hanzlamateen hanzlamateen deleted the instance-hooks branch October 15, 2023 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants