This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Changes for instance service hook refactor #9034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 75de7fc
This pull request refactors the usage of the
app.service(instancePath)service in various modules and test cases. It replaces the internal methods with the public ones, and removes some unnecessary or redundant code. The goal is to improve the consistency, readability, and compatibility of the code with the FeathersJS framework.References
#8871
Explanation
🤖 Generated by Copilot at 75de7fc
app.service(instancePath)service to avoid using undocumented and unsupported FeathersJS methods (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)instanceservice by using imported types and classes, and avoiding internal methods (link, link)KnexServiceclass as the base class for theInstanceServiceclass, and remove unnecessary constructor and methods (link, link, link)appparameter from the constructor of theInstanceServiceclass, since it is not needed anymore (link)instance.class.tsfile (link)🤖 Generated by Copilot at 75de7fc
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist