Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

@HexaField
Copy link
Contributor

@HexaField HexaField commented Jul 14, 2023

Summary

  • Fixes netcode for authority transfer
  • Implements Event Sourcing for Grabbables
  • Renames equippables to grabbables
  • Fixes testing configuration problems

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

process.env.TS_NODE_FILES = true
process.env.TS_NODE_PROJECT = 'tsconfig.json'
process.env.TS_NODE_COMPILER_OPTIONS = '{\"module\": \"commonjs\" }'
process.env.NODE_TLS_REJECT_UNAUTHORIZED='0'

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.

process.env.APP_ENV = 'test'
process.env.NODE_ENV = 'test'
process.env.NODE_TLS_REJECT_UNAUTHORIZED='0'

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
process.env.TS_NODE_FILES = true
process.env.TS_NODE_PROJECT = 'tsconfig.json'
process.env.TS_NODE_COMPILER_OPTIONS = '{\"module\": \"commonjs\" }'
process.env.NODE_TLS_REJECT_UNAUTHORIZED='0'

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
process.env.TS_NODE_FILES = true
process.env.TS_NODE_PROJECT = 'tsconfig.json'
process.env.TS_NODE_COMPILER_OPTIONS = '{\"module\": \"commonjs\" }'
process.env.NODE_TLS_REJECT_UNAUTHORIZED='0'

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
process.env.TS_NODE_FILES = true
process.env.TS_NODE_PROJECT = 'tsconfig.json'
process.env.TS_NODE_COMPILER_OPTIONS = '{\"module\": \"commonjs\" }'
process.env.NODE_TLS_REJECT_UNAUTHORIZED='0'

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
process.env.TS_NODE_COMPILER_OPTIONS = '{\"module\": \"commonjs\" }'
process.env.APP_ENV = 'test'
process.env.NODE_ENV = 'test'
process.env.NODE_TLS_REJECT_UNAUTHORIZED='0'

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
process.env.TS_NODE_PROJECT = 'tsconfig.json'
process.env.TS_NODE_COMPILER_OPTIONS = '{\"module\": \"commonjs\" }'
process.env.NODE_ENV = 'test'
process.env.NODE_TLS_REJECT_UNAUTHORIZED='0'

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
process.env.TS_NODE_PROJECT = 'tsconfig.json'
process.env.TS_NODE_COMPILER_OPTIONS = '{\"module\": \"commonjs\" }'
process.env.NODE_TLS_REJECT_UNAUTHORIZED='0' No newline at end of file
process.env.NODE_ENV = 'test'

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
@HexaField HexaField marked this pull request as ready for review July 18, 2023 07:13
@HexaField HexaField requested a review from speigg July 18, 2023 07:14
@speigg
Copy link
Contributor

speigg commented Jul 19, 2023

When a new client joins, the grabbable does not appear in the current position.

@HexaField
Copy link
Contributor Author

When a new client joins, the grabbable does not appear in the current position.

you'll need to reinit your db, this is due to it spawning as a fixed rigidbody and not dynamic. the problem with this then though, is it falls through the floor because the skybase loads after it

@HexaField HexaField merged commit 9f64e91 into dev Jul 19, 2023
@HexaField HexaField deleted the event-sourcing-grabbables branch July 19, 2023 04:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants