This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Updated client to prefer lowest-res video when video is small. #8225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
suggested changes
Jul 5, 2023
Rendering 1080p video for every user with their camera on can be taxing on a user's device when several people have their cameras on. Additionally, it's very hard to tell the difference in quality when the video is so small. Made consumers prefer the lowest spatial layer (resolution) unless PiP is on, at which point it switches to the highest spatial layer, or if immersive media is enabled, which will use either the top layer-1 if there are more than 2, or 0 if there are not. Updated user window order so that the user's own screen/cam come at the top. Replaced tcp-port-detect with detect-port, as the former was not detecting certain processes that were actively running.
barankyle
force-pushed
the
downgrade-thumbnail-video-quality
branch
from
c031868 to
7a2035e
Compare
HexaField
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rendering 1080p video for every user with their camera on can be taxing on a user's
device when several people have their cameras on. Additionally, it's very hard to
tell the difference in quality when the video is so small. Made consumers prefer the
lowest spatial layer (resolution) unless PiP is on, at which point it switches to
the highest spatial layer, or if immersive media is enabled, which will use either
the top layer-1 if there are more than 2, or 0 if there are not.
Updated user window order so that the user's own screen/cam come at the top.
Replaced tcp-port-detect with detect-port, as the former was not detecting certain
processes that were actively running.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.