Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

@aditya-mitra
Copy link
Contributor

@aditya-mitra aditya-mitra commented Jun 17, 2023

Summary

image

References

closes #7903

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField
Copy link
Contributor

Let's move the button next to the refresh button

@aditya-mitra
Copy link
Contributor Author

Let's move the button next to the refresh button

@HexaField The previous download button was only for downloading projects. Since the refresh button belongs to the FileBrowserContentPanel, do we also want to handle downloading of individual files?

@HexaField
Copy link
Contributor

Let's move the button next to the refresh button

@HexaField The previous download button was only for downloading projects. Since the refresh button belongs to the FileBrowserContentPanel, do we also want to handle downloading of individual files?

Yeah we want this in the file browser UI itself

@aditya-mitra
Copy link
Contributor Author

I have now moved the download button to the file browser UI !
image

@aditya-mitra aditya-mitra requested a review from HexaField June 19, 2023 04:31
Copy link
Contributor

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To protect against abuse, let's allow the downloader to only allow downloads from /projects/* paths, such that any other path (including /projects) are disallowed. This should be done in the service, and return an Error otherwise.

@aditya-mitra aditya-mitra requested a review from HexaField June 19, 2023 07:07
Copy link
Contributor

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great from the admin panel, but when I click the download button in the file browser in the studio, it downloads as undefined.zip

@aditya-mitra aditya-mitra requested a review from HexaField June 19, 2023 18:29
@aditya-mitra
Copy link
Contributor Author

Works great from the admin panel, but when I click the download button in the file browser in the studio, it downloads as undefined.zip

Fixed this!

@aditya-mitra aditya-mitra force-pushed the feat/admin-projects-download-button branch from 39e80a4 to f1f4324 Compare June 19, 2023 18:30
@HexaField
Copy link
Contributor

Last thing, let's hide the button for non-project directories. (nested directories in a project are fine)

@aditya-mitra
Copy link
Contributor Author

Last thing, let's hide the button for non-project directories. (nested directories in a project are fine)

Sure. Implementing this!

@HexaField HexaField added this pull request to the merge queue Jun 21, 2023
Merged via the queue into dev with commit 2879adb Jun 21, 2023
@HexaField HexaField deleted the feat/admin-projects-download-button branch June 21, 2023 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move project "download" button into File Browser panel

2 participants