This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Added logic to prevent reconnection warning when switching media servers #8042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaInstanceConnectionService now has a field 'joiningNewMediaChannel'. This is set to true when actively switching from one media server to another, and to false once connected to that server. Media disconnection actions will not display the warning modal if joiningNewMediaChannel is true, as they were disconnected for a non-error reason. Added an indicator that media connection is still in progress.
HexaField
approved these changes
Jun 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MediaInstanceConnectionService now has a field 'joiningNewMediaChannel'. This is set to true when actively switching from one media server to another, and to false once connected to that server.
Media disconnection actions will not display the warning modal if joiningNewMediaChannel is true, as they were disconnected for a non-error reason.
Added an indicator that media connection is still in progress.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.