-
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
|
Please resolve typescript errors |
|
I have removed the ts error. |
speigg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
HexaField
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern here is whether or not this will affect vscode nested repo searching, which is quite brittle at the moment. Let's add a gitignore for the generated project folder.
I am sorry for the late reply. I think it is automatically added to gitignore (it seems to be defined in the root gitignore) |
Oh right, we are not initializing a git repo, so it probably won't pick it up. Regardless, I will test it myself to make sure before merging this in. |

Summary
Unit Tests for server-core's route service
References
Refs #5997
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.