Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

@aditya-mitra
Copy link
Contributor

Summary

Unit Tests for server-core's route service

References

Refs #5997

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@aditya-mitra aditya-mitra marked this pull request as draft March 30, 2023 04:21
@aditya-mitra aditya-mitra marked this pull request as ready for review April 6, 2023 03:13
@aditya-mitra aditya-mitra requested a review from HexaField April 7, 2023 04:04
@HexaField
Copy link
Contributor

Please resolve typescript errors

@aditya-mitra
Copy link
Contributor Author

I have removed the ts error.
There seems to be some DB connection error in the branch-build/compile-codebase job.

Copy link
Contributor

@speigg speigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is whether or not this will affect vscode nested repo searching, which is quite brittle at the moment. Let's add a gitignore for the generated project folder.

@aditya-mitra
Copy link
Contributor Author

aditya-mitra commented Apr 27, 2023

My only concern here is whether or not this will affect vscode nested repo searching, which is quite brittle at the moment. Let's add a gitignore for the generated project folder.

I am sorry for the late reply.

image

I think it is automatically added to gitignore (it seems to be defined in the root gitignore)

@aditya-mitra aditya-mitra requested a review from HexaField April 27, 2023 12:07
@HexaField
Copy link
Contributor

My only concern here is whether or not this will affect vscode nested repo searching, which is quite brittle at the moment. Let's add a gitignore for the generated project folder.

I am sorry for the late reply.

image

I think it is automatically added to gitignore (it seems to be defined in the root gitignore)

Oh right, we are not initializing a git repo, so it probably won't pick it up. Regardless, I will test it myself to make sure before merging this in.

@speigg speigg enabled auto-merge May 2, 2023 03:40
@speigg speigg added this pull request to the merge queue May 30, 2023
Merged via the queue into ir-engine:dev with commit bcc4b62 May 30, 2023
@aditya-mitra aditya-mitra deleted the tests/route branch June 1, 2023 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants