Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

@speigg
Copy link
Contributor

@speigg speigg commented Mar 27, 2023

  • Cleaned up seeder logic to use feathers api directly, rather than underlying sequelize model (which will be removed after we update to Feathers 5 schemas)
  • Improved template matching logic, to eliminate the need for checking the Model schema for unique columns
  • Brought back logic to filter out *setting tables, which only need to be seeded once
  • Refactored new Promise(async () => {}) anti-pattern
  • Added npm run prepare-database to .vscode/launch.json config for easier debugging

Cleanup seeder logic, filter setting tables.
@speigg speigg requested a review from aditya-mitra March 27, 2023 19:03
@speigg speigg marked this pull request as draft March 27, 2023 19:11
@speigg speigg marked this pull request as ready for review March 27, 2023 19:55
@speigg speigg requested a review from hanzlamateen March 28, 2023 01:59
@hanzlamateen hanzlamateen added this pull request to the merge queue Mar 28, 2023
Merged via the queue into dev with commit 848b428 Mar 28, 2023
@hanzlamateen hanzlamateen deleted the cleanup-seeder branch March 28, 2023 03:25
@hanzlamateen hanzlamateen mentioned this pull request Mar 29, 2023
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants