Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Conversation

@HexaField
Copy link
Contributor

@HexaField HexaField commented Mar 14, 2023

Summary

  • Adds a new object to the Network interface named transport that begins to abstract the network I/O
  • Replaces Network classes with objects for tighter reactive bindings
  • Cleans up some references and state in the server

References

closes #7179

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField requested review from barankyle and speigg and removed request for barankyle March 14, 2023 01:18
@HexaField HexaField marked this pull request as ready for review March 14, 2023 02:47
Copy link
Contributor

@speigg speigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@speigg speigg added this pull request to the merge queue Mar 14, 2023
Merged via the queue into dev with commit 7c7dbe7 Mar 14, 2023
@speigg speigg deleted the network-transport-abstraction branch March 14, 2023 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Story] Refactor Network Class into Hookstate and Functions

2 participants