This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Fix Visemes #7494
Merged
Fix Visemes #7494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Visemes have been broken for a few reasons:
The webworker was not being loaded properly locally, vite seems to have a bug with relative URL imports.
A flipped larger than check was causing data to never populate.
There was a bit of awkwardness an inefficiency around the previous implementation. Avatar skinned meshes are now cached on the AvatarRigComponent for easy access, rather than having to traverse down the avatar's object heirarchy.
The WebcamInputComponent has also been updated to the new component definition, as well as using bitecs under the hood for future network serialization.
References
partially addresses #7495
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.