This repository was archived by the owner on Aug 21, 2024. It is now read-only.
'isHMD' check improvements #7400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
added a commit
that referenced
this pull request
Jan 2, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 4, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 4, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 5, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 5, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 5, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 5, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 6, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 6, 2023
dinomut1
pushed a commit
that referenced
this pull request
Jan 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isHMDpreviously was only true for navigator user agents that contain 'Quest', this creates a somewhat more robust check that should enable this heuristic for a wider range of HMDs. Specifically, it checks for the presence ofnavigator.xr, and against mobiles, and the WebXR Emulator.In the future, we should find a better heuristic that is more deterministic, that ideally doesn't require promises, and without entering a session.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.