This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Serve Client From API #7351
Merged
Serve Client From API #7351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barankyle
force-pushed
the
server-client-from-api
branch
from
cace656 to
4aa0042
Compare
barankyle
force-pushed
the
server-client-from-api
branch
from
4aa0042 to
8c2bce8
Compare
barankyle
force-pushed
the
server-client-from-api
branch
from
8c2bce8 to
b4bcc1b
Compare
barankyle
force-pushed
the
server-client-from-api
branch
4 times, most recently
from
66423e7 to
2bcb4eb
Compare
Added configurable ability to build and serve client files from API pods instead of standalone client pods. Added a new API Dockerfile that builds the API and client portions in separate stages, then copies just the built client files into the final image. build_and_publish_package.sh now takes an additional parameter for the Dockerfile name, so that there can be multiple Dockerfiles for the same service. In this case, the api server can be built plainly with Dockerfile-api, or with the client included with Dockerfile-api-client.
barankyle
force-pushed
the
server-client-from-api
branch
from
2bcb4eb to
5d2be3e
Compare
barankyle
approved these changes
May 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A summary of changes being made in this PR
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.